docs: Link out to FOSSRIT Runbook (closes #86)#89
Merged
Conversation
justwheel
added
improvement
justwheel
requested review from
Nolski and
wilfriedE
and removed request for
a team
justwheel
force-pushed
the
change/readme-contributing
branch
2 times, most recently
from
75473e4 to
8878efc
Compare
kevinassogba
requested changes
Feb 24, 2020
|
|
||
| More detailed steps will be documented in the future. | ||
| For now, if you want to contribute, submit a new pull request. | ||
| See the [_Website (fossrit.github.io)_](https://runbook.fossrit.community/infra/website/ "Website (fossrit.github.io) - FOSSRIT Runbook") page in the [FOSSRIT Runbook](https://runbook.fossrit.community/). |
Member
There was a problem hiding this comment.
Are you keeping this in a single file on purpose? An alternative is to copy this section, and paste it in the How to Contribute section of the ReadMe.
Member
Author
There was a problem hiding this comment.
@10eMyrT I am! The GitHub user interface makes the CONTRIBUTING.md more visible in the GitHub.com interface. Instead of deleting the file, I want to benefit from the improved visibility on GitHub.com but at least point out to the Runbook if someone does come across it.
Comment on lines
+16
to
+18
| ## How to contribute | ||
|
|
||
| For help with contributing and making a development environment, see [CONTRIBUTING.md](https://github.com/FOSSRIT/fossrit.github.io/blob/master/.github/CONTRIBUTING.md). | ||
| See the [_Website (fossrit.github.io)_](https://runbook.fossrit.community/infra/website/ "Website (fossrit.github.io) - FOSSRIT Runbook") page in the [FOSSRIT Runbook](https://runbook.fossrit.community/). |
Member
There was a problem hiding this comment.
Since we are not referring to the CONTRIBUTING.md file any more, copying and pasting sounds better to me.
kevinassogba
approved these changes
Feb 24, 2020
Serubin
reviewed
Feb 25, 2020
Serubin
suggested changes
Feb 25, 2020
Member
Serubin
left a comment
Serubin
left a comment
There was a problem hiding this comment.
Minor typo - otherwise looks great
justwheel
added a commit
that referenced
this pull request
Feb 25, 2020
Signed-off-by: Justin W. Flory <git@jwf.io>
This commit follows up on previous Runbook PRs, FOSSRIT/runbook#30 and FOSSRIT/runbook#32. Now that contributing guidelines and advice about maintaining this site lives in the Runbook, the duplicated info is removed from this repo. Instead, the reader is redirected to the Runbook. Stay D.R.Y. - Don't Repeat Yourself! Closes #86. Signed-off-by: Justin W. Flory <git@jwf.io>
justwheel
force-pushed
the
change/readme-contributing
branch
from
b97ddf3 to
3a27d34
Compare
Member
Author
|
Thanks @10eMyrT and @Serubin for reviewing! Going to merge this now. 🌊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit follows up on previous Runbook PRs, FOSSRIT/runbook#30 and
FOSSRIT/runbook#32. Now that contributing guidelines and advice about
maintaining this site lives in the Runbook, the duplicated info is
removed from this repo. Instead, the reader is redirected to the
Runbook.
Stay D.R.Y. - Don't Repeat Yourself!
Closes #86.