Note lack of feature parity with RITlug site (closes #87)#92
Merged
Note lack of feature parity with RITlug site (closes #87)#92
Conversation
justwheel
added
improvement
justwheel
requested review from
kennedy and
kevinassogba
and removed request for
a team
ct-martin
reviewed
Feb 26, 2020
Member
ct-martin
left a comment
ct-martin
left a comment
There was a problem hiding this comment.
Something to the effect of "however, the codebase has since diverged based on our needs" might be more discreet if you want the same effect without potentially implying one site is better than the other.
You're also missing a comma after "however"
Otherwise, LGTM; I like the alt/title text on the link
whenbellstoll
approved these changes
Feb 26, 2020
Member
whenbellstoll
left a comment
whenbellstoll
left a comment
There was a problem hiding this comment.
Good to note. Approved. Closes #92
justwheel
force-pushed
the
change/87-ritlug-disclaimer
branch
from
2646ba3 to
d87fd2a
Compare
Member
kevinassogba
left a comment
kevinassogba
left a comment
There was a problem hiding this comment.
Looks useful to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a note to the README that this website does not have
full feature parity with the RITlug site, and links to issue #87 where
there is more specific details on the differences.
Closes #87.