Merged
Conversation
The favicons in the source list contained the title of the feed in their alt attribute. This was redundant since the title is already shown next to the item, resulting in the title being read multiple times by accessibility technologies. It was also displayed over the title when the favicon file was missing. Closes: #975
On Heroku and other services, client side resources are not installed since the client package.json is in a subdirectory. We need to install them manually. This commit adds the client installation script into postinstall hook. Please note that you still need to enable node.js buildpack (or carry out an equivalent procedure for your PaaS) for the hook to be run.
Different languages have different typographic conventions. For that reason, it does not make sense to include colons in the templates – instead the translators should decide what is the usual way form fields are designated and use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.