feat: remove Gradle extension #6579
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the Gradle Enterprise Maven Extension with the Takari Smart Builder for parallel build optimization and removes the associated Gradle Enterprise configuration.
Key Changes:
- Removed Gradle Enterprise Maven Extension and its configuration file
- Added Takari Smart Builder extension (version 1.1.0)
- Introduced maven.config with batch mode and parallelization flags
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.mvn/extensions.xml |
Replaced Gradle Enterprise extension with Takari Smart Builder extension |
.mvn/maven.config |
Added new configuration file with batch mode and parallel build flags |
.mvn/gradle-enterprise.xml |
Removed Gradle Enterprise configuration file (no longer needed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.mvn/maven.config
Outdated
| @@ -0,0 +1,3 @@ | |||
| -b | |||
| smart | |||
There was a problem hiding this comment.
The "smart" option is not a valid Maven command-line flag. The Takari Smart Builder is already activated through the extension in extensions.xml, so no additional flag is needed here. This line should be removed to prevent Maven from failing with an "Unrecognized option" error.
| smart |
.mvn/maven.config
Outdated
| @@ -0,0 +1,3 @@ | |||
| -b | |||
| smart | |||
| -T2C | |||
There was a problem hiding this comment.
The "-T2C" flag enables Maven's parallel build mode with 2 threads per CPU core. However, this conflicts with the Takari Smart Builder extension which has its own parallel build strategy. Using both simultaneously can lead to unpredictable behavior or build failures. Since the PR's purpose is to use Takari Smart Builder for parallelization, the "-b" flag (batch mode) should be used alone or with Smart Builder's specific configuration options, not with Maven's native thread-based parallelism.
| -T2C |
|
https://github.com/takari/takari-smart-builder either copilot is smarter as their docs or .... |
MartinWitt
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SirYwell
left a comment
SirYwell
left a comment
There was a problem hiding this comment.
might be rather chore: than feat: but looks okay.
Let's just remove the really outdated extension; this wasn't updated for 4 years by us.