review: refactor: remove reflection needed on Java pre 17 #6582
+12
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
looks good when CI is green. |
Collaborator
|
thanks @SirYwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before switching to Java 17, we already supported some features that require Java 16/17 methods for the reflection model. Since then, we can drop this workaround and just call the method directly.
JavaReflectionVisitor,MethodHandleUtils, andJavaReflectionVisitorImplare package-private, so compatibility isn't an issue here. The only problem would be the changed method signature inJavaReflectionTreeBuilder, but I think this is acceptable.