AdminIT.testBannerMessages failing on Rocky 9

[donsizemore]

This test has failed consistently enough on Rocky 9 that I feel it's worth reporting:

"[ERROR] AdminIT.testBannerMessages:863 expected: <OK> but was: <ERROR>"

Unfortunately I don't find anything more helpful in the stack of server.logs generated during end-to-end tests.

Related to #10271

[donsizemore]

@jp-tosca as of May 13 2024 on Rocky 9 this test still fails:
[ERROR] AdminIT.testBannerMessages:864 expected: <OK> but was: <ERROR>

[jp-tosca]

FTR: After some testing it seems that there is something wrong with the endpoint in Rocky IX 🥊.

Thanks @donsizemore for all the help with testing this.

After doing some changes on the test and eliminating points of failure we concluded that in this environment a valid call is producing a success output with an unexpected result.

A simple call like this:

curl -H "Content-type:application/json" -X POST "http://localhost:8080/api/admin/bannerMessage" --data '{"dismissibleByUser":"false","messageTexts":[{"lang":"en","message":"Banner Message For Deletion"},{"lang":"fr","message":"Banner Message For Deletion"}]}'

Will generate in Rocky IX 🥊 the following output:

{"status":"OK","data":{"message":"Banner Message added successfully."}}

But when checking with:

$ curl http://localhost:8080/api/admin/bannerMessage

We get something like this : {"status":"OK","data":[{"id":0,"displayValue":""}]}
When this is expected: {"status":"OK","data":[{"id":0,"displayValue":"Banner Message For Deletion"}]}

So far it doesn't seem to be an exception or anything on the back but I will post as soon as I find more details

[jp-tosca]

This test is failing because:

dataverse/src/main/java/edu/harvard/iq/dataverse/BannerMessage.java

Line 51 in da3dd95

if (msgTxt.getLang().equals(BundleUtil.getCurrentLocale().getLanguage())) {

Use the locale to define what message to return, rocky is returning "c".

On the test, this line will call the method UtilIT.getBannerMessageIdFromResponse:

dataverse/src/test/java/edu/harvard/iq/dataverse/api/AdminIT.java

Line 856 in da3dd95

String deleteId = UtilIT.getBannerMessageIdFromResponse(getBannerMessageResponse.getBody().asString());

Which is searching explicitly from this string Banner Message For Deletion:

dataverse/src/test/java/edu/harvard/iq/dataverse/api/UtilIT.java

Line 3382 in da3dd95

if (message.equals("Banner Message For Deletion")) {

And the value is empty

{
    "status": "OK",
    "data": [
        {
            "id": 0,
            "displayValue": ""
        }
    ]
}

[donsizemore]

This doesn't require code changes within Dataverse -- this problem is specific to the Rocky 9 AWS AMI. Closing in favor of gdcc/dataverse-ansible#352