-
Notifications
You must be signed in to change notification settings - Fork 531
DisplayOnCreate Fixes #11343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisplayOnCreate Fixes #11343
Conversation
'IQSS/10476-display-on-create-field-option-new' into 10476-display-on-create-field-option-new
'IQSS/10476-display-on-create-field-option-new' into 10476-display-on-create-field-option-new
'IQSS/10476-display-on-create-field-option-new' into 10476-display-on-create-field-option-new
'IQSS/10476-display-on-create-field-option-new' into 10476-display-on-create-field-option-new
src/main/java/edu/harvard/iq/dataverse/MetadataBlockServiceBean.java
Outdated
Show resolved
Hide resolved
|
Bad force-push caused a close |
GPortas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great overall—just a few minor points that would be nice to clarify, but given the priority, it's ready for approval.
src/test/java/edu/harvard/iq/dataverse/engine/command/impl/CreateDataverseCommandTest.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java
Outdated
Show resolved
Hide resolved
GPortas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
pdurbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to reproduce the bugs I've seen on develop:
- I can see all the fields I expect
- performance is better
|
I pushed this PR to internal and tried creating a dataset and noticed that some fields were missing i.e., keyword, related publication - citation block, and notes. Screen.Recording.2025-03-17.at.3.10.54.PM.mov |
|
Guessing this is issues on internal - I see that the notes fieldtype has required = false there - probably from earlier testing. Re loading the citation /other blocks may help. |
|
Thanks @qqmyers - after I reloaded the metadata block in internal, I was able to see the fields that were initially missing. |

What this PR does / why we need it: Addresses the bugs and performance issues found manually after the merge of #11312. Specific changes include:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: