Skip to content

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 11, 2025

What this PR does / why we need it: The current implementation of CSL Styles citations adds an extra doi: in the DOI URL shown, e.g.
image

This PR fixes that:
image

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: Look at a CSL citation in the UI before/after, verify that the unnecessary/incorrect doi: is removed. Could check with PermaLinks as well.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@qqmyers qqmyers added this to the 6.8 milestone Jul 11, 2025
@qqmyers qqmyers added the Size: 0.5 A percentage of a sprint. 0.35 hours label Jul 11, 2025
@coveralls
Copy link

coveralls commented Jul 11, 2025

Coverage Status

coverage: 23.182%. remained the same
when pulling e64fae0 on GlobalDataverseCommunityConsortium:CSLFix
into 74b3bc7 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but the fix makes sense. Approved.

@github-project-automation github-project-automation bot moved this to Ready for QA ⏩ in IQSS Dataverse Project Jul 14, 2025
@cmbz cmbz added FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) labels Jul 17, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jul 21, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jul 21, 2025
@ofahimIQSS
Copy link
Contributor

Fix looks good - merging

@ofahimIQSS ofahimIQSS merged commit 237243a into IQSS:develop Jul 23, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jul 23, 2025
@ofahimIQSS ofahimIQSS removed their assignment Jul 23, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jul 24, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
aliassheikh added a commit to DANS-KNAW/dataverse that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) Size: 0.5 A percentage of a sprint. 0.35 hours

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

5 participants