-
Notifications
You must be signed in to change notification settings - Fork 531
feat: "Link Dataset/Dataverse" permission (now with Flyway migration script) #11691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,39 @@ | |||
| /* We're adding new permissions at bit 13 (4096 LinkDataverse) and bit 14 (8192 LinkDataset). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to rename this script to 6.7.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, 6.7.1.1 since we start at 1.
Also, heads up that this PR is in a race with PR #11654 for that number. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, let's see if I make it :) done.
sekmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor issue - you'll need to update the name of the script because this will go in after the release of 6.7.1
ofahimIQSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving version bump
|
tests passed - performed additional regression testing in internal. merging! |
What this PR does / why we need it:
This is a resubmission of #11534:
This resubmission now includes a SQL file to migrate the
permissionbitscolumn in thedataverseroletable:https://github.com/vera/dataverse/blob/00a45f525f34fc2d9dce3104c4ff16c10fe6c534/src/main/resources/db/migration/V6.6.0.4.sql#L1-L4
I've tested the SQL migration file and it correctly migrates the permission bits:
Before:
After:
Which issue(s) this PR closes:
Special notes for your reviewer:
/
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
/
Is there a release notes update needed for this change?:
Additional documentation:
/