chore:update leader-elect chart config#168
chore:update leader-elect chart config#168InftyAI-Agent merged 1 commit intoInftyAI:mainfrom qinguoyi:feat-deploy-any-ns
Conversation
kerthcet
left a comment
There was a problem hiding this comment.
Sorry, I should explain more clear about the advices, what we need is just an example about how to configure the controller args.
Please squash the commit after addressing the comments. Thanks.
|
/kind documentation |
chore:update leader-elect chart config
|
tk, as suggested, I re-push the code. but, i still have a question, what is the difference between value.yaml and value.global.yaml, because there are already complete examples to config in value.yaml |
That's a good question, the answer is values.yaml is autogenerated, if you take a look at the Anyway, we need to update the chart README.md to avoid such confusions. |
|
/lgtm Thanks @qinguoyi for your patience and efforts. |
What this PR does / why we need it
update leader-elect chart config
Which issue(s) this PR fixes
none
Special notes for your reviewer
Does this PR introduce a user-facing change?