feature(webhook): add BackendRuntimeConfig resources validation#170
Merged
InftyAI-Agent merged 1 commit intoInftyAI:mainfrom Sep 23, 2024
Merged
feature(webhook): add BackendRuntimeConfig resources validation#170InftyAI-Agent merged 1 commit intoInftyAI:mainfrom
InftyAI-Agent merged 1 commit intoInftyAI:mainfrom
Conversation
InftyAI-Agent
added
needs-triage
Member
Author
|
Maybe we need to do some unit testing on the webhook, but this will be a lot of work |
Member
Author
|
/kind feature |
InftyAI-Agent
added
feature
googs1025
force-pushed
the
valid/resource
branch
from
bb82d14 to
c5d97f8
Compare
Member
|
Webhook tests usually covered by the integration test, and we do lack some kind of tests like updating validation. |
kerthcet
reviewed
Sep 21, 2024
Member
kerthcet
left a comment
kerthcet
left a comment
There was a problem hiding this comment.
Let's add an integration test under /test/integraton/webhook/playground_test.go
Member
Author
I will handle this tonight |
googs1025
force-pushed
the
valid/resource
branch
2 times, most recently
from
5253a51 to
bf20413
Compare
Member
Author
done. @kerthcet |
kerthcet
reviewed
Sep 23, 2024
| }, | ||
| failed: true, | ||
| }), | ||
| ginkgo.Entry("invalid BackendRuntime resources", &testValidatingCase{ |
Member
There was a problem hiding this comment.
Could you add another example to cover the scenario: resources in limits but not in requests to make sure there's no panic.
googs1025
force-pushed
the
valid/resource
branch
from
bf20413 to
e45b4f2
Compare
Member
|
/lgtm Thanks! @googs1025 |
InftyAI-Agent
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #135
Special notes for your reviewer
None
Does this PR introduce a user-facing change?