Skip to content

Conversation

@devrimyatar
Copy link
Contributor

@devrimyatar devrimyatar commented Jan 27, 2026

Prepare


Description

Target issue

closes #13092

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #13091,

Summary by CodeRabbit

  • Chores
    • Updated Jans Lock service installation to include and unpack an additional dependency package into the service library directory.
    • Ensure unpacked files receive correct ownership and permissions during installation, reducing missing-dependency issues and improving service startup reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

@devrimyatar devrimyatar added the kind-feature Issue or PR is a new feature request label Jan 27, 2026
@devrimyatar devrimyatar requested a review from iromli as a code owner January 27, 2026 15:08
@devrimyatar devrimyatar added the comp-jans-linux-setup Component affected by issue or PR label Jan 27, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

Added a new jans-lock-server-service-deps-pack.zip artifact to JansLockInstaller.source_files and updated install_as_service to extract that zip into the custom lib directory and recursively set ownership to the Jetty user/group during service installation.

Changes

Cohort / File(s) Summary
JansLock service installer
jans-linux-setup/jans_setup/setup_app/installers/jans_lock.py
Added (dist_jans_dir, JANS_MAVEN) entry for jans-lock-server-service-deps-pack.zip to JansLockInstaller.source_files; in install_as_service unpack the new zip into the custom_lib_dir and recursively chown files to the Jetty user/group.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • iromli
  • yuriyz
  • yurem
  • yuriyzz
  • duttarnab
🚥 Pre-merge checks | ✅ 1 | ❌ 4
❌ Failed checks (2 warnings, 2 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes extracting grpc dependencies to jans-auth custom libs, but the actual changes are in jans_lock.py involving jans-lock server dependencies, not jans-auth gRPC. Correct the title to accurately reflect that the changes apply to jans-lock server dependencies instead of jans-auth gRPC dependencies.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive Issue #13092 is vague with placeholder template text and no specific requirements. The code changes extract jans-lock server deps, but the issue title mentions jans-auth gRPC, creating ambiguity about actual requirements. Clarify issue #13092 with specific requirements about extracting jans-lock server dependencies and confirm whether the code changes align with the intended feature scope.
Out of Scope Changes check ❓ Inconclusive The changes focus on jans-lock server dependency extraction and file ownership management, but the linked issue title references jans-auth gRPC, suggesting potential scope misalignment. Verify that jans-lock dependency extraction is the intended scope or clarify if changes should also address jans-auth gRPC dependencies as the issue title suggests.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description includes the required issue link (#13092) and documentation impact confirmation, but lacks detailed implementation explanation for the technical changes made.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto
Copy link
Member

mo-auto commented Jan 27, 2026

Error: Hi @devrimyatar, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto
Copy link
Member

mo-auto commented Jan 27, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Image Critical Image High Image Medium Image Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@jans-linux-setup/jans_setup/setup_app/installers/jans_lock.py`:
- Around line 123-126: Fix the comment typo and remove the fragile magic index
when extracting the gRPC artifact: change the comment to "directory" and replace
the hard-coded self.source_files[6][0] used in the base.unpack_zip call by
locating the correct artifact name in self.source_files (e.g., search for the
entry whose filename or metadata matches "grpc" or the expected artifact
identifier) before calling base.unpack_zip; reference the same target directory
base.current_app.JansAuthInstaller.custom_lib_dir and, if desired, introduce a
named constant (e.g., GRPC_ARTIFACT_KEY) or a small lookup helper to make the
selection explicit and robust.
- Line 124: After unpacking the ZIP with base.unpack_zip into
base.current_app.JansAuthInstaller.custom_lib_dir, add a recursive ownership
change using self.chown to set Config.jetty_user and Config.jetty_group on that
directory (mirror the pattern used earlier for plugin copies and in
jans_auth.py/jans_casa.py); also inspect the ZIP layout and the with_par_dir
parameter used by base.unpack_zip to ensure extracted JARs land in the intended
custom_lib_dir (if they end up in a subdirectory, call unpack_zip with
with_par_dir=False or adjust the chown target accordingly).

@sonarqubecloud
Copy link

@yurem yurem merged commit ecf8358 into main Jan 27, 2026
43 of 46 checks passed
@yurem yurem deleted the jans-linux-setup-jans-lock-deps-13086 branch January 27, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request

Projects

None yet

4 participants