-
Notifications
You must be signed in to change notification settings - Fork 160
feat(jans-linux-setup): extract grpc dependencies to jans-auth custom libs directors #13090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… libs directors Signed-off-by: Mustafa Baser <[email protected]>
📝 WalkthroughWalkthroughAdded a new jans-lock-server-service-deps-pack.zip artifact to JansLockInstaller.source_files and updated install_as_service to extract that zip into the custom lib directory and recursively set ownership to the Jetty user/group during service installation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (2 warnings, 2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Error: Hi @devrimyatar, You did not reference an open issue in your PR. I attempted to create an issue for you. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@jans-linux-setup/jans_setup/setup_app/installers/jans_lock.py`:
- Around line 123-126: Fix the comment typo and remove the fragile magic index
when extracting the gRPC artifact: change the comment to "directory" and replace
the hard-coded self.source_files[6][0] used in the base.unpack_zip call by
locating the correct artifact name in self.source_files (e.g., search for the
entry whose filename or metadata matches "grpc" or the expected artifact
identifier) before calling base.unpack_zip; reference the same target directory
base.current_app.JansAuthInstaller.custom_lib_dir and, if desired, introduce a
named constant (e.g., GRPC_ARTIFACT_KEY) or a small lookup helper to make the
selection explicit and robust.
- Line 124: After unpacking the ZIP with base.unpack_zip into
base.current_app.JansAuthInstaller.custom_lib_dir, add a recursive ownership
change using self.chown to set Config.jetty_user and Config.jetty_group on that
directory (mirror the pattern used earlier for plugin copies and in
jans_auth.py/jans_casa.py); also inspect the ZIP layout and the with_par_dir
parameter used by base.unpack_zip to ensure extracted JARs land in the intended
custom_lib_dir (if they end up in a subdirectory, call unpack_zip with
with_par_dir=False or adjust the chown target accordingly).
Signed-off-by: Mustafa Baser <[email protected]>
Signed-off-by: Mustafa Baser <[email protected]>
|



Prepare
Description
Target issue
closes #13092
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:to indicate documentation changes or if the below checklist is not selected.Closes #13091,
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.