Undo action not working with shapes

[thomaslima]

Hi,

I just laid out a box, or a path, then pressed Cmd+z (or manually via edit > undo create box/path), and the action was not undone. Moreover, the redo did not re-insert the object.

Note: Undo/redo action works fine with rulers. And also with Cell Instances. Can you reproduce?

[klayoutmatthias]

Hi Thomas,

I'm sorry, I'm not able to reproduce it. I am creating a simple example - empty layout, create one layer, add a rectangle. Undo works. Same for other shapes.

So it's either the context or the configuration. Did you do something special before or can you reproduce that with a layout from scratch.

With respect to the configuration, the "background combination mode" may be confusing - if this mode is not "Add" the effects may be strange:

Best regards,

Matthias

[thomaslima]

Hi Matthias,

I have tried with the -nc option. It must be only my compilation, or the Mac ones (qt > 5.10)

Another datapoint: The add layer event can be reversed.

Do you use qt5 as well? It would be helpful if we had the same qt in all platforms.

Best,

[klayoutmatthias]

Hi Thomas,

sorry for the delayed response. I am using Qt4 still on Linux, but on Windows I'm using 5.6.2. On both platforms I don't see the issue.

But I do see the issue on my VirtualBox MacOS. I'll try to debug that.

Best regards,

Matthias

[klayoutmatthias]

Found the issue. It should work now. It was a difference in the linking of RTTI information - clang requires classes to have uniform public visibility to allow dynamic_cast. But only on Mac and only in release build. That's why it was difficult to debug.

Thanks for reporting the problem.

Matthias

[thomaslima]

Thank you so much! I will test it and let you know.

[thomaslima]

Just tested without cleaning build directory. Problem persists.

[thomaslima]

Rebuilt and tested afresh. problem still persists on my MacOS with qt 5.10.1.

[klayoutmatthias]

(please imagine me cursing ...) I was quite proud having found the issue ... So what works for me (after the fix) with Qt 5.9.3 from MacPort: - create a new layout - create a new layer (1/0) - draw a box - use "Edit/Undo": the box vanishes Are you testing the same? Or a different combination? The root cause is not detected by the compiler nor does it give a warning at runtime. So I cannot rule out other occurances of the problem. Any hints are welcome. Best regards, Matthias Quoting Thomas Ferreira de Lima <notifications@github.com>:

…

Rebuilt and tested afresh. problem still persists on my MacOS with qt 5.10.1. -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: #107 (comment)

[thomaslima]

Unfortunately I have no hints so far, except that I am compiling with Qt 5.10.1 and doing the same steps that you are doing. I was even careful enough to start klayout with -nc -e -rx options. I saw you included a unit test on that but I still have to learn how to run it.

[thomaslima]

Weird. The test passed!

[thomaslima]

Ok I kind of have a false alarm. When I execute klayout from the built binary folder, your patch works. But when I execute Kaazz's deploy script to a klayout bundle, the undo button stops working. very weird. I have to investigate more.

[thomaslima]

I'd like to share something very curious. I activated the flag DYLD_PRINT_LIBRARIES while launching klayout from both folders, and recorded which libraries were loaded while loading the app. Results are attached.
dyld_libs.txt (bin)
dyld_libs.txt (pkg)

The packaged version loaded the same libraries, but also some extra ones:

> dyld: loaded: /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera
> dyld: loaded: /System/Library/PrivateFrameworks/MobileAsset.framework/Versions/A/MobileAsset
> dyld: loaded: /System/Library/PrivateFrameworks/StreamingZip.framework/Versions/A/StreamingZip
> dyld: loaded: /System/Library/Frameworks/MediaToolbox.framework/Versions/A/MediaToolbox
> dyld: loaded: /System/Library/PrivateFrameworks/CoreAVCHD.framework/Versions/A/CoreAVCHD
> dyld: loaded: /System/Library/Frameworks/MediaAccessibility.framework/Versions/A/MediaAccessibility
> dyld: loaded: /System/Library/PrivateFrameworks/Mangrove.framework/Versions/A/Mangrove
> dyld: loaded: /System/Library/Frameworks/CoreMedia.framework/Versions/A/CoreMedia
> dyld: loaded: /System/Library/Frameworks/VideoToolbox.framework/Versions/A/VideoToolbox
> dyld: loaded: /System/Library/PrivateFrameworks/CoreAUC.framework/Versions/A/CoreAUC
> dyld: loaded: /usr/lib/libspindump.dylib
> dyld: loaded: /usr/lib/libdscsym.dylib
> dyld: loaded: /System/Library/PrivateFrameworks/AppleVA.framework/Versions/A/AppleVA```

[thomaslima]

Launched the klayout with debug level 100 and watched events play out. In the pkg folder's klayout, the menu item undo does not produce any output whatsoever. Just ignored.

In the bin folder's klayout, the debug shows that klayout captured the undo action and executed it.

The very same libraries are loaded for both events except the ones above. (In the bin's case, libspindump and libdscsym are loaded right when I actually draw a box.

[thomaslima]

I just tested @Kazzz-S 's latest compilation and it works! It must have something to do with brew's qt 5.10.1, which is probably different than macport's one. :(