Edit layer specification doesn't work well with PCells

[jurask]

When there is PCell inserted in layer, changing layer properties (number, datatype) does not work properly. When the GDS file is saved, PCell geometry is still in original layer.

Steps to reproduce:

1. create new layout
2. Insert some PCell into it
3. Change layer number via Edit layer specification - PCell geometry will be under new layer number
4. Save the GDS
5. Restart KLayout and open the file
6. PCell geometry will be in the original layer as before point 3

[klayoutmatthias]

I see.

The problem is that you're renaming the layer which temporarily shifts the PCell's shapes to the new layer. But the PCell parameter is still referring to the old layer. So when the PCell is regenerated on loading, the old layer will be restored.

I think it's possible to make the layout rename change the PCell parameters as well.

Thanks for reporting this.

Matthias

[jurask]

Thanks for help, when I edit properties from GUI, it works now fine. Unfortunately, when I edit the layer from script using Layout.set_info(index, pya.LayerInfo(n, datatype)) the PCells geometry is still under original layer number. Should I open new issue, or am I doing something wrong?

[klayoutmatthias]

No, this will not work. PCell parameters and the layer info data fields are separate entities. If you do a scripted change, you'll need to modify the PCell parameters.

[jurask]

ok, for anyone, who will find this, this is how I made it working

...
oldinfo = layout.get_info(layerindex)
newinfo = LayerInfo(lay, datatype)
layout.set_info(layerindex, newinfo)
self.updatePcells(oldinfo, newinfo)
...


def updatePcells(self, oldinfo, newinfo):
    view = Application.instance().main_window().current_view()
    layout = view.active_cellview().layout()
    for cell in layout.cells("*"):
        for inst in cell.each_inst():
            if inst.is_pcell():
                params = inst.pcell_parameters_by_name()
                for param in params:
                    if isinstance(inst.pcell_parameter(param), LayerInfo):
                        if inst.pcell_parameter(param) == oldinfo:
                            inst.change_pcell_parameter(param, newinfo)