Deny sending and receiving shared media redirects#288
Merged
adrelanos merged 2 commits intoKicksecure:masterfrom Jan 10, 2025
raja-grewal:shared_media
Merged
Deny sending and receiving shared media redirects#288adrelanos merged 2 commits intoKicksecure:masterfrom raja-grewal:shared_media
adrelanos merged 2 commits intoKicksecure:masterfrom
raja-grewal:shared_media
Conversation
Contributor
|
Seems fine to me, worst-case scenario it makes the network less efficient from my research, and there seems to be a good argument for setting this option. Edit: Minor nitpick, but there seems to be some extra whitespace (two spaces in a row) in the comments above the actual sysctl option. |
Contributor
Author
|
Thanks for the review! I have removed the double space. The other double spaces in the README.md are there to limit line length. Yes, enabling this |
Contributor
|
@adrelanos Looks good to me, should be merge-ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #279 (comment).
Changes
Set
sysctl net.ipv4.conf.*.shared_media=0Mandatory Checklist
Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint
Optional Checklist
The following items are optional but might be requested in certain cases.