Skip to content

Deny sending and receiving shared media redirects#288

Merged
adrelanos merged 2 commits intoKicksecure:masterfrom
raja-grewal:shared_media
Jan 10, 2025
Merged

Deny sending and receiving shared media redirects#288
adrelanos merged 2 commits intoKicksecure:masterfrom
raja-grewal:shared_media

Conversation

@raja-grewal
Copy link
Contributor

As per #279 (comment).

Changes

Set sysctl net.ipv4.conf.*.shared_media=0

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@ArrayBolt3
Copy link
Contributor

ArrayBolt3 commented Dec 20, 2024

Seems fine to me, worst-case scenario it makes the network less efficient from my research, and there seems to be a good argument for setting this option.

Edit: Minor nitpick, but there seems to be some extra whitespace (two spaces in a row) in the comments above the actual sysctl option.

@raja-grewal
Copy link
Contributor Author

Thanks for the review!

I have removed the double space. The other double spaces in the README.md are there to limit line length.

Yes, enabling this sysctl does not appear to have any real strong downsides to me either.

@ArrayBolt3
Copy link
Contributor

@adrelanos Looks good to me, should be merge-ready.

@adrelanos adrelanos merged commit 27d19ba into Kicksecure:master Jan 10, 2025
@raja-grewal raja-grewal deleted the shared_media branch January 11, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments