feat: get gRPC descriptor via server reflection#210
Merged
LinuxSuRen merged 4 commits intoLinuxSuRen:masterfrom Sep 6, 2023
Merged
feat: get gRPC descriptor via server reflection#210LinuxSuRen merged 4 commits intoLinuxSuRen:masterfrom
LinuxSuRen merged 4 commits intoLinuxSuRen:masterfrom
Conversation
Signed-off-by: Ink33 <Ink33@smlk.org>
LinuxSuRen
reviewed
Sep 6, 2023
Owner
LinuxSuRen
left a comment
LinuxSuRen
left a comment
There was a problem hiding this comment.
I left a few comments. I don't block this PR. You can do it in this PR or not, it's your choice.
LinuxSuRen
added
enhancement
Owner
|
By the way, you can remove or comment the following line if you want to depress the non-related CI errors. api-testing/.github/workflows/build.yaml Line 52 in c582610 |
Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>
Ink-33
force-pushed
the
grpc_reflection
branch
2 times, most recently
from
e7aa12c to
fd91104
Compare
but ci is still angry Signed-off-by: Ink33 <Ink33@smlk.org>
Ink-33
force-pushed
the
grpc_reflection
branch
from
fd91104 to
0c7d7c7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
LinuxSuRen
approved these changes
Sep 6, 2023
| atest convert -p .github/testing/core.yaml --converter jmeter -t sample.jmx | ||
| - name: Report API Test | ||
| uses: harupy/comment-on-pr@c0522c44600040927a120b9309b531e3cb6f8d48 | ||
| uses: thollander/actions-comment-pull-request@v2 |
Owner
There was a problem hiding this comment.
This is better and maintained well.
LinuxSuRen
pushed a commit
that referenced
this pull request
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
The format of gRPC api name has been changed form
service.methodto/package.service/method.For detail, see
sample/grpc-sample.yaml.Now we can set
spec.grpc.serverReflection: trueto enable getting descriptor form gRPC server which has registered as a reflection server.related #160