feat: Support set different image registry server#271
feat: Support set different image registry server#271LinuxSuRen merged 7 commits intoLinuxSuRen:masterfrom im-jinxinwang:fix_259
Conversation
Signed-off-by: jinxinwang <g1561925068@163.com>
A modified version
LinuxSuRen
left a comment
LinuxSuRen
left a comment
There was a problem hiding this comment.
Thanks for your effort. I left some comments, please take a look at it.
helm/api-testing/Chart.yaml
Outdated
| dependencies: | ||
| - name: common | ||
| repository: oci://registry-1.docker.io/bitnamicharts | ||
| tags: | ||
| - bitnami-common | ||
| version: 2.x.x |
There was a problem hiding this comment.
What is reason to add this dependency?
There was a problem hiding this comment.
There are a large number of public libraries in bitnami-common, which can be used to form a specification
There was a problem hiding this comment.
Got it. But how about using it when this chart is completed enough. In my view, it's pretty simple. I didn't find a solid reason to use a third-party chart.
helm/api-testing/values.yaml
Outdated
| replicaCount: 1 | ||
|
|
||
| image: | ||
| registry: docker.io |
There was a problem hiding this comment.
I prefer to use linuxsuren.docker.scarf.sh as the default registry. It is a mirror of docker.io. Because it could collect more information about the pulling data.
helm/api-testing/values.yaml
Outdated
| registry: docker.io | ||
| repository: linuxsuren/api-testing | ||
| pullPolicy: IfNotPresent | ||
| tag: "v0.0.2-helm" |
There was a problem hiding this comment.
v0.0.2-helm is the tag of the helm image instead of the application. I perfer to use the chart appVersion as the default version instead of a fixed version.
There was a problem hiding this comment.
The fixed version is indeed not dynamic enough, but it is not user-friendly because after I download the chart, I still need to look at the code to know which image tag I am using.
There was a problem hiding this comment.
But the tag v0.0.2-helm is incorrect.
Signed-off-by: jinxinwang <g1561925068@163.com>
helm/api-testing/Chart.lock
Outdated
| dependencies: | ||
| - name: common | ||
| repository: oci://registry-1.docker.io/bitnamicharts | ||
| version: 2.13.3 | ||
| digest: sha256:9a971689db0c66ea95ac2e911c05014c2b96c6077c991131ff84f2982f88fb83 | ||
| generated: "2023-11-14T09:58:21.488814356+08:00" |
Signed-off-by: jinxinwang <g1561925068@163.com>
Signed-off-by: jinxinwang <g1561925068@163.com>
Signed-off-by: jinxinwang <g1561925068@163.com>
Signed-off-by: jinxinwang <g1561925068@163.com>
|
Kudos, SonarCloud Quality Gate passed!
|
LinuxSuRen
changed the title
2 participants
Fix issue [259] Support set different image registry server