feat: add the cookie setting for golang code generator#361
Closed
shiyang1026 wants to merge 1 commit intoLinuxSuRen:masterfrom
Closed
feat: add the cookie setting for golang code generator#361shiyang1026 wants to merge 1 commit intoLinuxSuRen:masterfrom
shiyang1026 wants to merge 1 commit intoLinuxSuRen:masterfrom
Conversation
|
|
|
Contributor
Author
|
When I lay in bed, ready to fall asleep, I realized I hadn't added unit tests. I plan to complete it tomorrow.😂 |
LinuxSuRen
reviewed
Apr 14, 2024
Owner
LinuxSuRen
left a comment
LinuxSuRen
left a comment
There was a problem hiding this comment.
Actually, you don't need to create a new PR. I'm going to close this due to it is duplicated with #363
Contributor
Author
|
Thanks for clearing that up. I get it now |
Owner
|
Here is my personal experience. Please feel free to read it if you are interested in it. |
LinuxSuRen
pushed a commit
that referenced
this pull request
Jun 17, 2024
* chore(deps): update getmeili/meilisearch docker tag to v1.3.2 * Update app version --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-action update-app-version <githubaction@githubaction.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved this issue: Add the cookie setting for Golang code generator #360 .
And there is a bug in the same file
main.ho.tpl, on line 19, The comma used to separate parameters was placed outside of the quotation marks. Since they are in one file, I don't think it's necessary to create a separate pull request just for this bug.