Skip to content

feat: support to generate json format report#98

Merged
LinuxSuRen merged 1 commit intoLinuxSuRen:masterfrom
setcy:json
Jun 19, 2023
Merged

feat: support to generate json format report#98
LinuxSuRen merged 1 commit intoLinuxSuRen:masterfrom
setcy:json

Conversation

@setcy
Copy link
Contributor

@setcy setcy commented Jun 19, 2023

close: #78

Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. It's great.

I left some comments. Please feel free to check them. And there is one more comment.

It would be more clear if we could put the new format into the command help message. See also

flags.StringVarP(&opt.report, "report", "", "", "The type of target report. Supported: markdown, md, html, discard, std")

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Welcome to be the fifth contributor.

By the way, it's not necessary to use force push because the maintainer will squash and merge PR.

@LinuxSuRen LinuxSuRen merged commit ca1a69c into LinuxSuRen:master Jun 19, 2023
@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support to generate JSON format report

2 participants