Feature/cores3 mic#1552
Conversation
|
The changes look good. One suggestion. It is relatively expensive to convert from stereo to mono in JavaScript. An alternative would be for the audio input class to accept the |
|
Thanks for the suggestion. I found that simply using channels: 1 is sufficient in our case. AudioIn already implements stereo→mono conversion (it takes the L channel), so there’s no need for JS-side mixing. When I want stereo, channels: 2 already gives me stereo samples, which is good enough so far. |
|
@meganetaaan – thank you for making the change. Setting |
|
This change has been merged and will be available in the next release. |
This is a draft PR to add microphone support for M5Stack CoreS3
Changes
M5Stack CoreS3 Target
ES7210 Driver (setup-target.js)
Audio Input Module (modules/io/audioin/esp32/audioin.c and modules/pins/audioin/esp32/audioin.c)