add typing embedded:io/bluetoothle/peripheral#1558
Closed
stc1988 wants to merge 6 commits intoModdable-OpenSource:publicfrom
Closed
add typing embedded:io/bluetoothle/peripheral#1558stc1988 wants to merge 6 commits intoModdable-OpenSource:publicfrom
stc1988 wants to merge 6 commits intoModdable-OpenSource:publicfrom
Conversation
phoddie
reviewed
Jan 11, 2026
Collaborator
phoddie
left a comment
phoddie
left a comment
There was a problem hiding this comment.
Overall, this looks really good. Thank you for taking care of this. I can cross one item off my to-do list. ;)
I added some comments for your review and consideration. If you don't want to make them, we can merge this, and we'll address them (mostly by adding ble/common.d.ts).
Contributor
Author
|
Thank you for the review. I made changes based on the review. |
Collaborator
|
Wonderful, thank you! I think we can still get this merged for our (late...) January release. |
Contributor
Author
|
OK. I started building the TypeScript application based on this type definition, but I found a few issues and fixed them. I’ve confirmed that the application can now be built. |
Collaborator
|
This change will be available in the next release. |
mkellner
pushed a commit
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.