Skip to content

[https://nvbugs/5752521][fix] Unwaive test_trtllm_flashinfer_symbol_collision.py#10227

Merged
yihwang-nv merged 1 commit intoNVIDIA:mainfrom
yihwang-nv:yihwang/fix_test_trtllm_flashinfer_symbol_collision_timeout
Jan 5, 2026
Merged

[https://nvbugs/5752521][fix] Unwaive test_trtllm_flashinfer_symbol_collision.py#10227
yihwang-nv merged 1 commit intoNVIDIA:mainfrom
yihwang-nv:yihwang/fix_test_trtllm_flashinfer_symbol_collision_timeout

Conversation

@yihwang-nv
Copy link
Collaborator

@yihwang-nv yihwang-nv commented Dec 23, 2025

description

Re-enabled a previously skipped test for MOE (Mixture of Experts) functionality, indicating resolution of a known issue.

@yihwang-nv
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2025

📝 Walkthrough

Walkthrough

A test skip entry was removed from the waive list, allowing the previously skipped test for test_flashinfer_fused_moe_matches_torch_moe to now execute during integration testing.

Changes

Cohort / File(s) Change Summary
Test Waive List
tests/integration/test_lists/waives.txt
Removed skip directive for unittest/_torch/attention/test_trtllm_flashinfer_symbol_collision.py::test_flashinfer_fused_moe_matches_torch_moe

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is completely empty, missing all required sections including description, test coverage, and PR checklist. Add a description explaining the issue and solution, list relevant test coverage, and complete the PR checklist items as required by the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the repository template format [NVBugs ID][type] Summary and accurately describes the main change: removing a test skip waiver.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 522f1d2 and 5b34ef0.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29573 [ run ] triggered by Bot. Commit: 5b34ef0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29573 [ run ] completed with state SUCCESS. Commit: 5b34ef0
/LLM/main/L0_MergeRequest_PR pipeline #22741 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yihwang-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29636 [ run ] triggered by Bot. Commit: 5b34ef0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29636 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 12 PM PST on 12/23.

@yihwang-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29704 [ run ] triggered by Bot. Commit: 5b34ef0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29704 [ run ] completed with state SUCCESS. Commit: 5b34ef0
/LLM/main/L0_MergeRequest_PR pipeline #22820 completed with status: 'SUCCESS'

@yihwang-nv yihwang-nv force-pushed the yihwang/fix_test_trtllm_flashinfer_symbol_collision_timeout branch from 5b34ef0 to fd7ddf8 Compare December 30, 2025 01:59
@yihwang-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30107 [ run ] triggered by Bot. Commit: fd7ddf8

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30107 [ run ] completed with state FAILURE. Commit: fd7ddf8
/LLM/main/L0_MergeRequest_PR pipeline #23167 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

…ollision.py

Signed-off-by: Yihan Wang <yihwang@nvidia.com>
@yihwang-nv yihwang-nv force-pushed the yihwang/fix_test_trtllm_flashinfer_symbol_collision_timeout branch from fd7ddf8 to a09aee0 Compare December 30, 2025 06:48
@yihwang-nv yihwang-nv enabled auto-merge (squash) December 30, 2025 13:55
@yihwang-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30180 [ run ] triggered by Bot. Commit: a09aee0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30180 [ run ] completed with state SUCCESS. Commit: a09aee0
/LLM/main/L0_MergeRequest_PR pipeline #23227 completed with status: 'SUCCESS'

@yihwang-nv yihwang-nv merged commit e7a4486 into NVIDIA:main Jan 5, 2026
5 checks passed
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
…ollision.py (NVIDIA#10227)

Signed-off-by: Yihan Wang <yihwang@nvidia.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants