Skip to content

Comments

[https://nvbugs/5701425][chore] Unwaive tests.#10269

Merged
yuxianq merged 9 commits intoNVIDIA:mainfrom
yuxianq:unwaive-ds-bf16-4gpus
Jan 5, 2026
Merged

[https://nvbugs/5701425][chore] Unwaive tests.#10269
yuxianq merged 9 commits intoNVIDIA:mainfrom
yuxianq:unwaive-ds-bf16-4gpus

Conversation

@yuxianq
Copy link
Collaborator

@yuxianq yuxianq commented Dec 24, 2025

Summary by CodeRabbit

  • Tests
    • Removed exclusions for DeepSeekV3Lite test configurations with bfloat16 precision and specific optimization settings, enabling previously skipped tests to run during test execution.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq yuxianq requested a review from EmmaQiaoCh December 24, 2025 08:15
@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 24, 2025

/bot run --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

📝 Walkthrough

Walkthrough

This PR removes two SKIP entries from the test waives file, enabling two previously excluded DeepSeekV3Lite test configurations to run. The changes modify test-exclusion behavior for specific parameter combinations without altering test logic or implementation.

Changes

Cohort / File(s) Summary
Test exclusion list
tests/integration/test_lists/waives.txt
Removed two SKIP directives for DeepSeekV3Lite test configurations: one with ep4-mtp_nextn=0 parameters and one with tp4-mtp_nextn=2 parameters, allowing these tests to execute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • EmmaQiaoCh
  • litaotju

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete and contains only the template boilerplate without the required sections filled in. Fill in the Description section explaining why these tests are being unwaived, and complete the Test Coverage section listing the affected tests.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically indicates the main change—removing test waivers from the excluded test list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29781 [ run ] triggered by Bot. Commit: ccbedf6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29781 [ run ] completed with state SUCCESS. Commit: ccbedf6
/LLM/main/L0_MergeRequest_PR pipeline #22889 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 25, 2025

/bot run --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29863 [ run ] triggered by Bot. Commit: a91ba2f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29863 [ run ] completed with state SUCCESS. Commit: a91ba2f
/LLM/main/L0_MergeRequest_PR pipeline #22967 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 25, 2025

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29941 [ run ] triggered by Bot. Commit: 7c22bbf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #29941 [ run ] completed with state SUCCESS. Commit: 7c22bbf
/LLM/main/L0_MergeRequest_PR pipeline #23029 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 30, 2025

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30120 [ run ] triggered by Bot. Commit: 42b096f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30120 [ run ] completed with state SUCCESS. Commit: 42b096f
/LLM/main/L0_MergeRequest_PR pipeline #23180 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 31, 2025

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30219 [ run ] triggered by Bot. Commit: 7ddf3ec

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30219 [ run ] completed with state SUCCESS. Commit: 7ddf3ec
/LLM/main/L0_MergeRequest_PR pipeline #23262 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Dec 31, 2025

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30263 [ run ] triggered by Bot. Commit: 566f87f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30263 [ run ] completed with state SUCCESS. Commit: 566f87f
/LLM/main/L0_MergeRequest_PR pipeline #23298 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 1, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30328 [ run ] triggered by Bot. Commit: ebbe20e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30328 [ run ] completed with state SUCCESS. Commit: ebbe20e
/LLM/main/L0_MergeRequest_PR pipeline #23360 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 1, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30346 [ run ] triggered by Bot. Commit: ebbe20e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30346 [ run ] completed with state SUCCESS. Commit: ebbe20e
/LLM/main/L0_MergeRequest_PR pipeline #23378 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 4, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30497 [ run ] triggered by Bot. Commit: ed89e94

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30497 [ run ] completed with state SUCCESS. Commit: ed89e94
/LLM/main/L0_MergeRequest_PR pipeline #23519 completed with status: 'SUCCESS'

@yuxianq yuxianq merged commit 5773a4d into NVIDIA:main Jan 5, 2026
5 checks passed
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants