Skip to content

Comments

[https://nvbugs/5726086][fix] update kimi-k2-1k1k dataset#10473

Merged
fredricz-20070104 merged 2 commits intoNVIDIA:mainfrom
yingguo-trt:bug_fix_5661741
Jan 7, 2026
Merged

[https://nvbugs/5726086][fix] update kimi-k2-1k1k dataset#10473
fredricz-20070104 merged 2 commits intoNVIDIA:mainfrom
yingguo-trt:bug_fix_5661741

Conversation

@yingguo-trt
Copy link
Collaborator

@yingguo-trt yingguo-trt commented Jan 7, 2026

Summary by CodeRabbit

  • Chores
    • Updated benchmark test dataset configurations for performance testing.

✏️ Tip: You can customize this high-level summary in your review settings.

@yingguo-trt
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

Two test configuration files in the wideep benchmark suite have been updated to reference a different dataset version. The dataset path has been modified from a 100,000-entry dataset to a 20,000-entry dataset for both accuracy and performance testing configurations.

Changes

Cohort / File(s) Summary
Wideep Test Configurations
tests/integration/defs/perf/disagg/test_configs/wideep/accuracy/kimi-k2-thinking-fp4_1k1k_ctx3_gen1_dep32_bs1024_eplb384_mtp0_ccb-NIXL.yaml, tests/integration/defs/perf/disagg/test_configs/wideep/perf/kimi-k2-thinking-fp4_1k1k_ctx3_gen1_dep32_bs1024_eplb384_mtp0_ccb-NIXL.yaml
Updated dataset_file path from disagg_datasets/kimi-k2-1024-1024-100000-ratio-1_for_serve.json to disagg_datasets/kimi-k2-1024-1024-20000-ratio-1_for_serve.json in both accuracy and performance test configurations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning Pull request lacks a written description; only PR metadata from GitHub is available. The description template requires sections for Description, Test Coverage, and PR Checklist. Add a comprehensive PR description following the template, explaining why the dataset was changed from 100000 to 20000 samples and the impact of this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating the kimi-k2 1k1k dataset configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30804 [ run ] triggered by Bot. Commit: c4187ba

@fredricz-20070104 fredricz-20070104 enabled auto-merge (squash) January 7, 2026 02:23
@fredricz-20070104
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30814 [ run ] triggered by Bot. Commit: c4187ba

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30814 [ run ] completed with state SUCCESS. Commit: c4187ba
/LLM/main/L0_MergeRequest_PR pipeline #23793 (Partly Tested) completed with status: 'SUCCESS'

@fredricz-20070104
Copy link
Collaborator

/bot reuse-pipeline

Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #30834 [ reuse-pipeline ] triggered by Bot. Commit: 259b033

@fredricz-20070104
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30844 [ reuse-pipeline ] triggered by Bot. Commit: 259b033

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30834 [ reuse-pipeline ] completed with state ABORTED. Commit: 259b033
Can't reuse PR_Github #30814 (Partly Tested) with status: SUCCESS

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30844 [ reuse-pipeline ] completed with state SUCCESS. Commit: 259b033
Reusing PR_Github #30814 (Partly Tested) for commit 259b033

@fredricz-20070104 fredricz-20070104 merged commit cbf8357 into NVIDIA:main Jan 7, 2026
5 checks passed
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
@yingguo-trt yingguo-trt deleted the bug_fix_5661741 branch January 20, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants