[https://nvbugs/5744432][fix] fix bench script test#10483
[https://nvbugs/5744432][fix] fix bench script test#10483Superjomn merged 2 commits intoNVIDIA:mainfrom
Conversation
Superjomn
force-pushed
the
fix-bench-script
branch
from
9d1b720 to
b702daf
Compare
📝 WalkthroughWalkthroughThe change adds execution of dataset preparation commands in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration/defs/test_e2e.py (1)
519-519: Consider passing the command list directly withoutshell=True.The command is constructed as a list but then joined into a string and executed with
shell=True, which is a potential security risk and less efficient. You can pass the list directly tocheck_outputwithout joining and removeshell=True:- check_output(" ".join(command), shell=True, env=self.llm_venv._new_env) + check_output(command, env=self.llm_venv._new_env)This approach is safer (avoids shell injection risks) and more Pythonic. Based on learnings and coding guidelines for secure subprocess usage.
However, if there's a specific reason for using
shell=True(e.g., the environment handling requires it), please verify that the current approach is necessary by checking if the command executes correctly with the suggested change.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/integration/defs/test_e2e.py
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+
Indent Python code with 4 spaces. Do not use tabs
Always maintain the namespace when importing Python modules, even if only one class or function from a module is used
Python filenames should use snake_case (e.g.,some_file.py)
Python classes should use PascalCase (e.g.,class SomeClass)
Python functions and methods should use snake_case (e.g.,def my_awesome_function():)
Python local variables should use snake_case, with prefixkfor variable names that start with a number (e.g.,k_99th_percentile)
Python global variables should use upper snake_case with prefixG(e.g.,G_MY_GLOBAL)
Python constants should use upper snake_case (e.g.,MY_CONSTANT)
Avoid shadowing variables declared in an outer scope in Python
Initialize all externally visible members of a Python class in the constructor
For Python interfaces that may be used outside a file, prefer docstrings over comments
Use comments in Python for code within a function, or interfaces that are local to a file
Use Google-style docstrings for Python classes and functions, which can be parsed by Sphinx
Python attributes and variables can be documented inline with the format"""<type>: Description"""
Avoid using reflection in Python when functionality can be easily achieved without reflection
When using try-except blocks in Python, limit the except clause to the smallest set of errors possible
When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible and use the else block for the main logic
Files:
tests/integration/defs/test_e2e.py
**/*.{cpp,cc,cxx,h,hpp,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification
Files:
tests/integration/defs/test_e2e.py
🧬 Code graph analysis (1)
tests/integration/defs/test_e2e.py (1)
tests/integration/defs/conftest.py (1)
llm_venv(716-733)
🪛 Ruff (0.14.10)
tests/integration/defs/test_e2e.py
519-519: Function call with shell=True parameter identified, security issue
(S604)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
|
/bot run --stage-list "DGX_H200-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #30854 [ run ] triggered by Bot. Commit: |
|
PR_Github #30854 [ run ] completed with state |
Superjomn
force-pushed
the
fix-bench-script
branch
from
b702daf to
c75361d
Compare
|
/bot run |
|
PR_Github #31337 [ run ] triggered by Bot. Commit: |
|
PR_Github #31337 [ run ] completed with state
|
Superjomn
force-pushed
the
fix-bench-script
branch
from
c75361d to
0ce95f6
Compare
|
/bot run |
|
PR_Github #31382 [ run ] triggered by Bot. Commit: |
|
PR_Github #31382 [ run ] completed with state |
|
/bot run |
|
PR_Github #31404 [ run ] triggered by Bot. Commit: |
|
PR_Github #31404 [ run ] completed with state |
|
/bot run |
12 similar comments
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
/bot run |
|
PR_Github #32747 [ run ] completed with state
|
|
/bot run |
|
/bot run --disable-fail-fast |
|
PR_Github #32939 [ run ] triggered by Bot. Commit: |
|
PR_Github #32939 [ run ] completed with state
|
|
/bot run |
|
PR_Github #32972 [ run ] triggered by Bot. Commit: |
|
PR_Github #32972 [ run ] completed with state
|
|
/bot run |
|
PR_Github #33028 [ run ] triggered by Bot. Commit: |
|
PR_Github #33028 [ run ] completed with state
|
|
/bot run |
|
PR_Github #33060 [ run ] triggered by Bot. Commit: |
|
PR_Github #33060 [ run ] completed with state
|
…h100.yml - Remove pre_merge section (4 GPU) from l0_dgx_h200.yml - Restore test_trtllm_bench_llmapi_launch to post_merge section in l0_dgx_h200.yml - Add test_trtllm_bench_llmapi_launch to pre_merge section in l0_dgx_h100.yml Signed-off-by: Yan Chunwei <328693+Superjomn@users.noreply.github.com>
Superjomn
force-pushed
the
fix-bench-script
branch
from
4fba05f to
5488c7e
Compare
|
/bot run |
|
PR_Github #34713 [ run ] triggered by Bot. Commit: |
|
PR_Github #34713 [ run ] completed with state
|
|
/bot run |
|
PR_Github #34757 [ run ] triggered by Bot. Commit: |
|
PR_Github #34757 [ run ] completed with state
|
|
/bot run |
Signed-off-by: Yan Chunwei <328693+Superjomn@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #34950 [ run ] triggered by Bot. Commit: |
|
PR_Github #34950 [ run ] completed with state |
Signed-off-by: Yan Chunwei <328693+Superjomn@users.noreply.github.com> Signed-off-by: Ahmet Inci <ainci@nvidia.com>
3 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.