Skip to content

Comments

[None][fix] Solve pillow version conflict#10537

Merged
Wanli-Jiang merged 1 commit intoNVIDIA:mainfrom
Wanli-Jiang:user/williamj/fix-deps-conflict
Jan 12, 2026
Merged

[None][fix] Solve pillow version conflict#10537
Wanli-Jiang merged 1 commit intoNVIDIA:mainfrom
Wanli-Jiang:user/williamj/fix-deps-conflict

Conversation

@Wanli-Jiang
Copy link
Collaborator

@Wanli-Jiang Wanli-Jiang commented Jan 8, 2026

Why?
gradio==4.44.1 will use pillow==10.4.0, while MMMU requires pillow==11

What?

  • Upgrade gradio to 5.4.0.
  • Unwaive all MMMU tests.

Summary by CodeRabbit

  • Chores

    • Updated gradio dependency to version 5.4.0
  • Tests

    • Enabled additional vision and multimodal model tests for expanded test coverage

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Wanli-Jiang Wanli-Jiang requested review from a team as code owners January 8, 2026 06:41
@Wanli-Jiang Wanli-Jiang force-pushed the user/williamj/fix-deps-conflict branch from c3c2715 to a217ad0 Compare January 8, 2026 06:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

This PR updates the gradio dependency version in the Qwen model examples from 4.44.1 to 5.4.0 and removes eight SKIP entries from the integration test waives list, potentially enabling previously exempted tests for various model configurations and multimodal evaluations.

Changes

Cohort / File(s) Summary
Dependencies
examples/models/core/qwen/requirements.txt
Updated gradio version from 4.44.1 to 5.4.0
Test Configuration
tests/integration/test_lists/waives.txt
Removed eight SKIP entries for accuracy and multimodal tests including TestNVILA_8B, TestVILA1_5_3B, TestQwen2_5_VL_7B, and related auto_dtype configurations

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides the reason and what changes are made, but lacks detailed Test Coverage and PR Checklist completion. Add a Test Coverage section listing relevant tests for verifying the gradio upgrade and MMMU test enablement, and complete the PR Checklist items appropriately.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change—solving a pillow version conflict by upgrading gradio.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Wanli-Jiang
Copy link
Collaborator Author

/bot run --disable-fail-fast

Copy link
Collaborator

@yechank-nvidia yechank-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx a lot for finding this issue.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31018 [ run ] triggered by Bot. Commit: a217ad0

@yechank-nvidia yechank-nvidia added the Multimodal Label for issues & PRs regarding Multimodal related objects label Jan 8, 2026
@tensorrt-cicd
Copy link
Collaborator

PR_Github #31018 [ run ] completed with state SUCCESS. Commit: a217ad0
/LLM/main/L0_MergeRequest_PR pipeline #23963 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@Wanli-Jiang
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31156 [ run ] triggered by Bot. Commit: a217ad0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31156 [ run ] completed with state FAILURE. Commit: a217ad0
/LLM/main/L0_MergeRequest_PR pipeline #24072 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@Wanli-Jiang
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31235 [ run ] triggered by Bot. Commit: a217ad0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31235 [ run ] completed with state SUCCESS. Commit: a217ad0
/LLM/main/L0_MergeRequest_PR pipeline #24139 completed with status: 'SUCCESS'

@Wanli-Jiang Wanli-Jiang force-pushed the user/williamj/fix-deps-conflict branch 2 times, most recently from 891106a to bda4f34 Compare January 12, 2026 07:53
@Wanli-Jiang
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31519 [ reuse-pipeline ] triggered by Bot. Commit: bda4f34

Why?
gradio==4.44.1 will use pillow==10.4.0, while MMMU requires pillow==11

What?
* Upgrade gradio to 5.4.0.
* Unwaive all MMMU tests.

Signed-off-by: Wanli Jiang <35160485+Wanli-Jiang@users.noreply.github.com>
@Wanli-Jiang Wanli-Jiang force-pushed the user/williamj/fix-deps-conflict branch from bda4f34 to 01f2900 Compare January 12, 2026 08:21
@Wanli-Jiang
Copy link
Collaborator Author

/bot reuse-pipeline

@Wanli-Jiang Wanli-Jiang enabled auto-merge (squash) January 12, 2026 08:36
@tensorrt-cicd
Copy link
Collaborator

PR_Github #31528 [ reuse-pipeline ] triggered by Bot. Commit: 01f2900

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31519 [ reuse-pipeline ] completed with state ABORTED. Commit: bda4f34
Can't reuse PR_Github #31235 with status: SUCCESS

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31528 [ reuse-pipeline ] completed with state SUCCESS. Commit: 01f2900
Reusing PR_Github #31235 for commit 01f2900

@Wanli-Jiang Wanli-Jiang merged commit 11da7e3 into NVIDIA:main Jan 12, 2026
5 checks passed
videodanchik pushed a commit to videodanchik/TensorRT-LLM that referenced this pull request Jan 14, 2026
Signed-off-by: Wanli Jiang <35160485+Wanli-Jiang@users.noreply.github.com>
Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Multimodal Label for issues & PRs regarding Multimodal related objects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants