Skip to content

Comments

[None][chore] Remove closed bugs#10586

Merged
xinhe-nv merged 10 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260111
Jan 16, 2026
Merged

[None][chore] Remove closed bugs#10586
xinhe-nv merged 10 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260111

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 11, 2026

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Removed test waivers across multiple test suites to enable previously skipped validations to run, increasing testing rigor and ensuring more comprehensive quality assurance across core functionality areas.

✏️ Tip: You can customize this high-level summary in your review settings.

@xinhe-nv xinhe-nv marked this pull request as ready for review January 14, 2026 03:11
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

This pull request removes 17 SKIP waiver entries from the test list configuration file, specifically for tests including TestDeepSeekV3Lite, TestLlama3_3NemotronSuper49Bv1, TestNemotronUltra, and guided_decoding tests, indicating these previously waived tests are no longer being skipped.

Changes

Cohort / File(s) Summary
Test Waiver List Cleanup
tests/integration/test_lists/waives.txt
Removed 17 SKIP entries for various accuracy and serving tests, reducing the overall set of waived tests

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • jieli-matrix
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description 'Remove closed bugs from waives.txt' is minimal and lacks required sections from the template such as detailed explanation, test coverage information, and PR checklist confirmation. Expand the description to include: detailed explanation of which bugs were closed and why they no longer need waiving, relevant test coverage information, and confirmation of the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Remove closed bugs' follows the required format and accurately describes the main change: removing entries from the waives.txt file that correspond to closed bugs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd22324 and 36291d6.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv
Copy link
Collaborator Author

/bot run

@xinhe-nv xinhe-nv enabled auto-merge (squash) January 14, 2026 03:13
@tensorrt-cicd
Copy link
Collaborator

PR_Github #31871 [ run ] triggered by Bot. Commit: 36291d6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31871 [ run ] completed with state SUCCESS. Commit: 36291d6
/LLM/main/L0_MergeRequest_PR pipeline #24680 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20260111 branch from 3ead9ef to cbc96b0 Compare January 14, 2026 06:53
@xinhe-nv
Copy link
Collaborator Author

/bot run

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20260111 branch from cbc96b0 to 3d01b44 Compare January 14, 2026 06:56
@tensorrt-cicd
Copy link
Collaborator

PR_Github #31913 [ run ] triggered by Bot. Commit: 3d01b44

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20260111 branch from 3d01b44 to dfccab7 Compare January 14, 2026 08:20
@tensorrt-cicd
Copy link
Collaborator

PR_Github #31913 [ run ] completed with state FAILURE. Commit: 3d01b44
/LLM/main/L0_MergeRequest_PR pipeline #24716 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31926 [ run ] triggered by Bot. Commit: dfccab7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31926 [ run ] completed with state SUCCESS. Commit: dfccab7
/LLM/main/L0_MergeRequest_PR pipeline #24727 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32075 [ run ] triggered by Bot. Commit: bebe9bf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32075 [ run ] completed with state SUCCESS. Commit: bebe9bf
/LLM/main/L0_MergeRequest_PR pipeline #24859 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@xinhe-nv
Copy link
Collaborator Author

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32112 [ run ] triggered by Bot. Commit: 3e20727

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32112 [ run ] completed with state SUCCESS. Commit: 3e20727
/LLM/main/L0_MergeRequest_PR pipeline #24892 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32253 [ reuse-pipeline ] triggered by Bot. Commit: b5642df

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32253 [ reuse-pipeline ] completed with state SUCCESS. Commit: b5642df
Reusing PR_Github #32112 (Partly Tested) for commit b5642df

@xinhe-nv xinhe-nv merged commit 0256c72 into NVIDIA:main Jan 16, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20260111 branch January 16, 2026 07:06
zheyuf pushed a commit to zheyuf/TensorRT-LLM that referenced this pull request Jan 29, 2026
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants