Skip to content

Comments

[None][test] adjust the dis-agg test timeout threshold#10800

Merged
Shixiaowei02 merged 1 commit intoNVIDIA:mainfrom
Shixiaowei02:user/xiaoweis/dis-agg-timeout
Jan 19, 2026
Merged

[None][test] adjust the dis-agg test timeout threshold#10800
Shixiaowei02 merged 1 commit intoNVIDIA:mainfrom
Shixiaowei02:user/xiaoweis/dis-agg-timeout

Conversation

@Shixiaowei02
Copy link
Collaborator

@Shixiaowei02 Shixiaowei02 commented Jan 19, 2026

Summary by CodeRabbit

  • Tests
    • Extended test timeout parameters for improved reliability during test execution.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Recently, the dis‑aggregation accuracy tests have been timing out, and the root cause remains unclear. To avoid blocking the CI pipeline, the timeout threshold is being adjusted.

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02 Shixiaowei02 requested a review from chuangz0 January 19, 2026 08:09
@Shixiaowei02
Copy link
Collaborator Author

/bot skip --comment "test threshold adjustment"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Two timeout constants in the disaggregated serving integration test were increased from 1200 to 3600 seconds to allow additional test execution time.

Changes

Cohort / File(s) Summary
Timeout Constants Update
tests/integration/defs/accuracy/test_disaggregated_serving.py
DEFAULT_TEST_TIMEOUT and DEFAULT_SERVER_WAITING_TIMEOUT increased from 1200 to 3600 seconds

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides a clear explanation of the issue (timeout problems in dis-agg tests) and the solution (adjusting timeout thresholds), but lacks structured sections and test coverage details. Consider adding a structured description with clear sections for what was changed, why it was necessary, and which tests safeguard these changes, following the repository template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and directly related to the main change—adjusting timeout constants in the disaggregated serving test file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32548 [ skip ] triggered by Bot. Commit: ad0be3a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32548 [ skip ] completed with state SUCCESS. Commit: ad0be3a
Skipping testing for commit ad0be3a

@Shixiaowei02 Shixiaowei02 merged commit 442d2e8 into NVIDIA:main Jan 19, 2026
8 of 9 checks passed
@Shixiaowei02 Shixiaowei02 deleted the user/xiaoweis/dis-agg-timeout branch January 19, 2026 09:02
zheyuf pushed a commit to zheyuf/TensorRT-LLM that referenced this pull request Jan 29, 2026
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants