Skip to content

Comments

[TRTLLM-10331][infra] Upload unittest sub results in slurm#10834

Merged
yiqingy0 merged 5 commits intoNVIDIA:mainfrom
yiqingy0:slurm_sub_results
Feb 10, 2026
Merged

[TRTLLM-10331][infra] Upload unittest sub results in slurm#10834
yiqingy0 merged 5 commits intoNVIDIA:mainfrom
yiqingy0:slurm_sub_results

Conversation

@yiqingy0
Copy link
Collaborator

@yiqingy0 yiqingy0 commented Jan 20, 2026

Summary by CodeRabbit

  • Tests
    • Enhanced test result retrieval to support multiple result files simultaneously, improving test result aggregation and consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yiqingy0
Copy link
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-1" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32719 [ run ] triggered by Bot. Commit: afd6d81

@yiqingy0
Copy link
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-1" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32722 [ run ] triggered by Bot. Commit: afd6d81

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32722 [ run ] completed with state SUCCESS. Commit: afd6d81
/LLM/main/L0_MergeRequest_PR pipeline #25326 (Partly Tested) completed with status: 'SUCCESS'

@yiqingy0 yiqingy0 marked this pull request as ready for review January 21, 2026 02:27
@yiqingy0 yiqingy0 requested review from a team as code owners January 21, 2026 02:27
@yiqingy0 yiqingy0 requested review from mzweilz and tburt-nv January 21, 2026 02:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

Modified the remote results download path pattern in Jenkins test configuration from a single file pattern (results.xml) to a wildcard pattern (results*.xml) to support downloading multiple result XML files when present.

Changes

Cohort / File(s) Summary
Jenkins test configuration
jenkins/L0_Test.groovy
Changed SCP download pattern from results.xml to results*.xml to capture multiple result files; aligns with existing junit invocation pattern

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty with only the template structure and no actual implementation details, justification, or test coverage information provided. Provide a clear description of the issue being solved, why the change is needed, and which tests validate the changes to results*.xml pattern modification.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the JIRA ticket (TRTLLM-10331), specifies the type as [infra], and describes the specific change: uploading unittest sub-results in Slurm. This aligns with the file summary showing changes to jenkins/L0_Test.groovy to support multiple result files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
yiqingy0 and others added 3 commits February 9, 2026 18:49
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
@yiqingy0
Copy link
Collaborator Author

yiqingy0 commented Feb 9, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35326 [ run ] triggered by Bot. Commit: c87f841

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35326 [ run ] completed with state SUCCESS. Commit: c87f841
/LLM/main/L0_MergeRequest_PR pipeline #27287 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yiqingy0
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35398 [ run ] triggered by Bot. Commit: c87f841

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35398 [ run ] completed with state SUCCESS. Commit: c87f841
/LLM/main/L0_MergeRequest_PR pipeline #27344 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35454 [ run ] triggered by Bot. Commit: c87f841

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35454 [ run ] completed with state SUCCESS. Commit: c87f841
/LLM/main/L0_MergeRequest_PR pipeline #27392 completed with status: 'SUCCESS'

@yiqingy0 yiqingy0 merged commit 21cdc39 into NVIDIA:main Feb 10, 2026
6 of 7 checks passed
@yiqingy0 yiqingy0 deleted the slurm_sub_results branch February 10, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants