Skip to content

Comments

[https://nvbugs/5800646][fix] Fix hang issue by avoid exposing UB buf…#10842

Merged
liji-nv merged 1 commit intoNVIDIA:release/1.2from
liji-nv:dev-liji-torch-compile-hang-1.2
Jan 27, 2026
Merged

[https://nvbugs/5800646][fix] Fix hang issue by avoid exposing UB buf…#10842
liji-nv merged 1 commit intoNVIDIA:release/1.2from
liji-nv:dev-liji-torch-compile-hang-1.2

Conversation

@liji-nv
Copy link
Collaborator

@liji-nv liji-nv commented Jan 20, 2026

…fer out of graph

Summary by CodeRabbit

  • New Features

    • Enhanced compilation optimization patterns for residual normalization operations with improved tensor handling
  • Tests

    • Re-enabled test coverage for model configurations across multiple GPU setups to expand quality assurance

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@liji-nv liji-nv requested a review from a team as a code owner January 20, 2026 12:27
@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 20, 2026

/bot run --stage_list "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 20, 2026

/bot run --stage_list "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Two changes are introduced: a new pattern matching function for AllReduce graph output handling in the compilation system, and removal of test skip markers for DeepSeekV3Lite bfloat16 configurations to enable previously gated test cases.

Changes

Cohort / File(s) Summary
Pattern Matching Enhancement
tensorrt_llm/_torch/compilation/patterns/ar_residual_norm.py
Introduces insert_copy_for_graph_output() function to insert copy operations for AllReduce outputs, ensuring non-UB semantics are preserved when outputs connect to graph outputs. Includes pattern matching verification and integration into UB pattern registration pipeline.
Test Configuration Updates
tests/integration/test_lists/waives.txt
Removes three SKIP markers for DeepSeekV3Lite bfloat16 4-GPU test configurations (ep4, tp4, and variants), enabling these previously gated test cases to run.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is largely incomplete and does not follow the required template structure. Fill in the 'Description' section with a clear explanation of the issue and solution, and specify relevant test(s) in the 'Test Coverage' section that validate the changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the correct NVBugs format with issue reference [https://nvbugs/5800646], type [fix], and clearly summarizes the main change: fixing a hang issue by avoiding exposure of UB buffer out of graph.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32746 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: --stage_list DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1

@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 21, 2026

/bot run --stage-list "DGX_H200-4_GPUs-PyTorch-Post-Merge-1, DGX_B200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32842 [ run ] triggered by Bot. Commit: 4306f0c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32842 [ run ] completed with state SUCCESS. Commit: 4306f0c
/LLM/release-1.2/L0_MergeRequest_PR pipeline #97 (Partly Tested) completed with status: 'SUCCESS'

@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 21, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32877 [ run ] triggered by Bot. Commit: 4306f0c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32877 [ run ] completed with state SUCCESS. Commit: 4306f0c
/LLM/release-1.2/L0_MergeRequest_PR pipeline #104 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@liji-nv liji-nv force-pushed the dev-liji-torch-compile-hang-1.2 branch 2 times, most recently from 3db2aba to a49e02c Compare January 21, 2026 13:15
@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 21, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32952 [ run ] triggered by Bot. Commit: a49e02c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32952 [ run ] completed with state SUCCESS. Commit: a49e02c
/LLM/release-1.2/L0_MergeRequest_PR pipeline #121 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@liji-nv liji-nv force-pushed the dev-liji-torch-compile-hang-1.2 branch 2 times, most recently from 8cddaf8 to cba2fd5 Compare January 22, 2026 09:29
@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 22, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33141 [ run ] triggered by Bot. Commit: cba2fd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33141 [ run ] completed with state SUCCESS. Commit: cba2fd5
/LLM/release-1.2/L0_MergeRequest_PR pipeline #159 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 23, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33307 [ run ] triggered by Bot. Commit: cba2fd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33307 [ run ] completed with state SUCCESS. Commit: cba2fd5
/LLM/release-1.2/L0_MergeRequest_PR pipeline #193 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@liji-nv liji-nv enabled auto-merge (squash) January 23, 2026 11:39
@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 23, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33376 [ run ] triggered by Bot. Commit: cba2fd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33376 [ run ] completed with state SUCCESS. Commit: cba2fd5
/LLM/release-1.2/L0_MergeRequest_PR pipeline #205 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 26, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33503 [ run ] triggered by Bot. Commit: cba2fd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33503 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 7 PM PST on 1/25.

@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 26, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33512 [ run ] triggered by Bot. Commit: cba2fd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33512 [ run ] completed with state SUCCESS. Commit: cba2fd5
/LLM/release-1.2/L0_MergeRequest_PR pipeline #221 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

…fer out of graph

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
@liji-nv liji-nv force-pushed the dev-liji-torch-compile-hang-1.2 branch from cba2fd5 to 9b9d468 Compare January 26, 2026 06:07
@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 26, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33534 [ run ] triggered by Bot. Commit: 9b9d468

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33534 [ run ] completed with state SUCCESS. Commit: 9b9d468
/LLM/release-1.2/L0_MergeRequest_PR pipeline #224 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@liji-nv
Copy link
Collaborator Author

liji-nv commented Jan 27, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33700 [ run ] triggered by Bot. Commit: 9b9d468

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33700 [ run ] completed with state SUCCESS. Commit: 9b9d468
/LLM/release-1.2/L0_MergeRequest_PR pipeline #239 completed with status: 'SUCCESS'

@liji-nv liji-nv merged commit 8802eaf into NVIDIA:release/1.2 Jan 27, 2026
5 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 5, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 5, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 6, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 6, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 6, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 7, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 8, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 9, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 9, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
chzblych pushed a commit that referenced this pull request Feb 9, 2026
#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
inciaf pushed a commit to inciaf/trtllm-energy-monitoring that referenced this pull request Feb 18, 2026
NVIDIA#10842)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Ahmet Inci <ainci@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants