Skip to content

Comments

[None][infra] Fix TRT-LLM data scratch mount point for gb10x#10880

Merged
EmmaQiaoCh merged 6 commits intoNVIDIA:mainfrom
EmmaQiaoCh:emma/fix_digits_mount
Jan 24, 2026
Merged

[None][infra] Fix TRT-LLM data scratch mount point for gb10x#10880
EmmaQiaoCh merged 6 commits intoNVIDIA:mainfrom
EmmaQiaoCh:emma/fix_digits_mount

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Jan 21, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Improved test data volume provisioning with conditional mounting and better error messaging when required test data paths are unavailable.
  • Chores

    • Updated testing infrastructure configuration for more flexible data volume handling across different deployment scenarios.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh EmmaQiaoCh requested review from a team as code owners January 21, 2026 07:28
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

The Jenkins L0 test script now conditionally mounts LLM data volumes based on path existence, checking /home/scratch.trt_llm_data_ci first, then falling back to /home/scratch.trt_llm_data, with explicit error handling if neither exists. A Kubernetes pod configuration block for specific node types is commented out, reverting to default blossom PVC path usage.

Changes

Cohort / File(s) Summary
LLM Volume Mount Conditional Logic
jenkins/L0_Test.groovy
Replaced unconditional host LLM data volume mount with conditional logic: attempts to mount /home/scratch.trt_llm_data_ci first (read-only); falls back to /home/scratch.trt_llm_data; throws error if neither exists. Moves volume mounting from static dockerArgs assembly into explicit Slurm node setup conditional branch. Disables Kubernetes pod configuration block adjusting llmModelVolume for specific node types (6000d/gh200), restoring default blossom PVC path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely a template with no actual content explaining the changes, rationale, or test coverage. Fill in the Description section explaining what mount issue is being fixed and why. Add Test Coverage section listing relevant tests. Complete the PR Checklist appropriately.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title '[None][infra] Fix TRT-LLM data scratch mount point for gb10x' is specific and relates to the main change: fixing conditional volume mounting for TRT-LLM data in the DL cluster infrastructure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "GB10-PyTorch-Post-Merge-1, RTXPro6000D-PyTorch-1, RTXPro6000D-PyTorch-2, GH200-TensorRT-Post-Merge-1, GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32899 [ run ] triggered by Bot. Commit: 49e1cf0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32899 [ run ] completed with state SUCCESS. Commit: 49e1cf0
/LLM/main/L0_MergeRequest_PR pipeline #25447 (Partly Tested) completed with status: 'SUCCESS'

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "GB10-PyTorch-Post-Merge-1, RTXPro6000D-PyTorch-1, RTXPro6000D-PyTorch-2, GH200-TensorRT-Post-Merge-1, GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2" --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33040 [ run ] triggered by Bot. Commit: 49e1cf0

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "GB10-PyTorch-Post-Merge-1, RTXPro6000D-PyTorch-1, RTXPro6000D-PyTorch-2, GH200-TensorRT-Post-Merge-1, GH200-PackageSanityCheck-PY312-DLFW, GH200-PackageSanityCheck-PY312-UB2404, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2" --disable-fail-fast --disable-reuse-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33043 [ run ] triggered by Bot. Commit: 49e1cf0

Signed-off-by: qqiao <qqiao@nvidia.com>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33043 [ run ] completed with state SUCCESS. Commit: 49e1cf0
/LLM/main/L0_MergeRequest_PR pipeline #25545 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33111 [ run ] triggered by Bot. Commit: bd175d3

@chzblych chzblych changed the title [None][infra] Fix mount for gb10x [None][infra] Fix TRT-LLM data scratch mount point for gb10x Jan 22, 2026
EmmaQiaoCh and others added 2 commits January 22, 2026 15:08
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33111 [ run ] completed with state SUCCESS. Commit: bd175d3
/LLM/main/L0_MergeRequest_PR pipeline #25592 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33128 [ run ] triggered by Bot. Commit: fc043e5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33128 [ run ] completed with state SUCCESS. Commit: fc043e5
/LLM/main/L0_MergeRequest_PR pipeline #25605 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33259 [ run ] triggered by Bot. Commit: 827c4f6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33259 [ run ] completed with state ABORTED. Commit: 827c4f6
LLM/main/L0_MergeRequest_PR #25692 (Blue Ocean) completed with status: ABORTED

@ZhanruiSunCh
Copy link
Collaborator

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33282 [ run ] triggered by Bot. Commit: 827c4f6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33282 [ run ] completed with state SUCCESS. Commit: 827c4f6
/LLM/main/L0_MergeRequest_PR pipeline #25695 (Partly Tested) completed with status: 'SUCCESS'

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33318 [ run ] triggered by Bot. Commit: 827c4f6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33318 [ run ] completed with state SUCCESS. Commit: 827c4f6
/LLM/main/L0_MergeRequest_PR pipeline #25723 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33350 [ run ] triggered by Bot. Commit: 827c4f6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33350 [ run ] completed with state SUCCESS. Commit: 827c4f6
/LLM/main/L0_MergeRequest_PR pipeline #25743 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33423 [ run ] triggered by Bot. Commit: 827c4f6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33423 [ run ] completed with state SUCCESS. Commit: 827c4f6
/LLM/main/L0_MergeRequest_PR pipeline #25800 completed with status: 'SUCCESS'

@EmmaQiaoCh EmmaQiaoCh merged commit 9d65b8b into NVIDIA:main Jan 24, 2026
5 checks passed
EmmaQiaoCh added a commit that referenced this pull request Jan 29, 2026
…#11056)

Signed-off-by: qqiao <qqiao@nvidia.com>
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 13, 2026
…10880) (NVIDIA#11056)

Signed-off-by: qqiao <qqiao@nvidia.com>
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 13, 2026
…10880) (NVIDIA#11056)

Signed-off-by: qqiao <qqiao@nvidia.com>
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 13, 2026
…10880) (NVIDIA#11056)

Signed-off-by: qqiao <qqiao@nvidia.com>
Signed-off-by: Emma Qiao <qqiao@nvidia.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants