[https://nvbugs/5826689][fix] replace etcd3 with etcd-sdk-python

[reasonsolo]

Also made a small change to support multi endpoint etcd url.

Summary by CodeRabbit

• Chores
  • Updated etcd3 dependency from Git-based version to pyetcd3 package, with internal refactoring of cluster connection handling to improve maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[reasonsolo]

/bot run --disable-fail-fast

[coderabbitai]

📝 Walkthrough

Walkthrough

Dependency replacement from Git-based etcd3 to pyetcd3 package. Updates all imports across four files and refactors cluster storage connection initialization to use a new _connect() method that constructs a MultiEndpointEtcd3Client from comma-separated URIs.

Changes

Cohort / File(s)	Summary
Dependency Update requirements.txt	Removed Git-based etcd3 dependency; added pyetcd3
Connection Logic Refactoring tensorrt_llm/serve/cluster_storage.py	Replaced etcd3 import with pyetcd (aliased as etcd3); added new static _connect(cluster_uri) method to parse comma-separated endpoint URLs and build MultiEndpointEtcd3Client; refactored __init__ and reconnect() to use new method
Import Updates tensorrt_llm/serve/metadata_server.py, tests/unittest/disaggregated/test_remoteDictionary.py	Replaced etcd3 import with pyetcd aliased as etcd3; no API usage changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete. While the required template is present, the critical sections (Description and Test Coverage) are empty with only placeholder comments. The PR checklist is partially checked but lacks substantive implementation details, rationale, or test documentation.	Add a detailed description explaining why etcd3 is being replaced with etcd-sdk-python, list affected test cases, and document any breaking changes or migration notes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: replacing etcd3 with etcd-sdk-python. It includes the NVBugs ticket reference and appropriate [fix] type designation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🤖 Fix all issues with AI agents

In `@tensorrt_llm/serve/cluster_storage.py`:
- Around line 471-475: The __init__ in ClusterStorage (function __init__)
currently has unused parameters cluster_name and **kwargs; to satisfy linters
either store them on the instance (e.g., self._cluster_name = cluster_name and
self._init_kwargs = kwargs) so they’re preserved for subclasses or future use,
or explicitly mark them as intentionally unused with a comment like “# noqa:
ARG002” next to the parameter usage; update the __init__ for the ClusterStorage
class accordingly and ensure any assigned attribute names (e.g., _cluster_name,
_init_kwargs) do not conflict with existing attributes.
- Around line 459-469: In _connect(cluster_uri: str) sanitize and validate each
endpoint before constructing etcd3.Endpoint: split cluster_uri, strip
whitespace, and if a URL lacks a scheme prepend a default (e.g., "http://")
before urlparse; ensure parsed_url.hostname is not None (skip and log a warning
if it is) and convert parsed_url.port to an int using a reasonable default port
(e.g., 2379) when port is None; set secure based on parsed_url.scheme ==
"https"; collect only valid etcd3.Endpoint objects and if none remain raise a
clear ValueError instead of passing an empty list to
etcd3.MultiEndpointEtcd3Client; reference symbols: _connect, cluster_uri,
parsed_url, endpoints, etcd3.Endpoint, and etcd3.MultiEndpointEtcd3Client.
- Around line 8-12: The import of the etcd client is wrong: replace the current
"pyetcd as etcd3" import with the correct pyetcd3 module import (e.g., import
pyetcd3 as etcd3 or import pyetcd3 and alias to etcd3) and update all references
to etcd3 types accordingly; specifically, ensure usages of Etcd3Exception,
Endpoint, MultiEndpointEtcd3Client and any call sites that construct the client
(e.g., code that calls etcd3.client(), etcd3.Endpoint(...), or catches
etcd3.Etcd3Exception) use the pyetcd3 API names and construction patterns as
defined by pyetcd3 so the module import and symbol names match the library.

[tensorrt-cicd]

PR_Github #32940 [ run ] triggered by Bot. Commit: ee84ffc

[tensorrt-cicd]

PR_Github #32940 [ run ] completed with state SUCCESS. Commit: ee84ffc
/LLM/release-1.2/L0_MergeRequest_PR pipeline #117 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[reasonsolo]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #33332 [ run ] triggered by Bot. Commit: 91853d8

[tensorrt-cicd]

PR_Github #33332 [ run ] completed with state SUCCESS. Commit: 91853d8
/LLM/release-1.2/L0_MergeRequest_PR pipeline #198 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[reasonsolo]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #33506 [ run ] triggered by Bot. Commit: effd6e8

[tensorrt-cicd]

PR_Github #33506 [ run ] completed with state SUCCESS. Commit: effd6e8
/LLM/release-1.2/L0_MergeRequest_PR pipeline #220 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[reasonsolo]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #33550 [ run ] triggered by Bot. Commit: effd6e8

[tensorrt-cicd]

PR_Github #33550 [ run ] completed with state SUCCESS. Commit: effd6e8
/LLM/release-1.2/L0_MergeRequest_PR pipeline #225 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.