Skip to content

Comments

[#10889][fix] fix pydantic deepcopy bug#11004

Merged
reasonsolo merged 1 commit intoNVIDIA:mainfrom
reasonsolo:bug5827937
Jan 27, 2026
Merged

[#10889][fix] fix pydantic deepcopy bug#11004
reasonsolo merged 1 commit intoNVIDIA:mainfrom
reasonsolo:bug5827937

Conversation

@reasonsolo
Copy link
Collaborator

@reasonsolo reasonsolo commented Jan 26, 2026

This PR will fix #10889

Summary by CodeRabbit

  • New Features

    • Added support for tool calls in disaggregated inference mode
    • Included example prompt demonstrating tool call behavior with function invocation
  • Tests

    • Added integration test for disaggregated tool call functionality

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

A new disaggregated test scenario for tool calls is introduced with supporting infrastructure: a JSON example file containing tool call prompts, updates to OpenAI client and service implementations for proper JSON serialization and request handling, and corresponding test definitions and configurations.

Changes

Cohort / File(s) Summary
Tool Call Example Data
examples/disaggregated/clients/tool_call_prompts.json
New JSON example file with a user prompt and assistant tool call response for weather function.
OpenAI Service Updates
tensorrt_llm/serve/openai_client.py, tensorrt_llm/serve/openai_disagg_service.py
Client: Added explicit mode="json" parameter to model_dump() for JSON serialization. Service: Replaced deepcopy-based context request cloning with model_copy update that sets disaggregated_params and enforces streaming configuration in a single operation.
Test Infrastructure
tests/integration/defs/disaggregated/test_disaggregated.py
Added new test function test_disaggregated_chat_completion_tool_calls with test configuration entry for "tool_calls" scenario; extended run_client_tests workflow to handle tool_calls by setting chat endpoint output and bypassing streaming/completion steps.
Test Registry
tests/integration/test_lists/test-db/l0_a10.yml
Added new test entry for disaggregated tool calls test with TinyLlama model to l0_a10 test list.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is incomplete, containing only the repository template with unfilled placeholders and no actual content in the Description or Test Coverage sections. Fill in the Description section explaining the pydantic deepcopy bug being fixed and why. Complete the Test Coverage section listing relevant tests. Check off the PR Checklist items to confirm compliance.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing a pydantic deepcopy bug related to issue #10889. It's specific, concise, and accurately reflects the primary fix in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@reasonsolo
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33589 [ run ] triggered by Bot. Commit: be4b509

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@tests/integration/defs/disaggregated/test_disaggregated.py`:
- Around line 796-817: The test function
test_disaggregated_chat_completion_tool_calls has an unused fixture argument
disaggregated_test_root causing a Ruff ARG001 lint error; rename the parameter
to _disaggregated_test_root (or prefix with an underscore) in the function
signature so the fixture is still injected but linting is satisfied, e.g.,
update the def line for test_disaggregated_chat_completion_tool_calls to use
_disaggregated_test_root and leave all other code (including src_dst_dict,
symlink setup, and run_disaggregated_test call) unchanged.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33589 [ run ] completed with state SUCCESS. Commit: be4b509
/LLM/main/L0_MergeRequest_PR pipeline #25910 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@reasonsolo
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33657 [ run ] triggered by Bot. Commit: be4b509

@reasonsolo reasonsolo enabled auto-merge (squash) January 27, 2026 03:06
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33657 [ run ] completed with state SUCCESS. Commit: be4b509
/LLM/main/L0_MergeRequest_PR pipeline #25966 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@reasonsolo
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33676 [ run ] triggered by Bot. Commit: be4b509

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33676 [ run ] completed with state SUCCESS. Commit: be4b509
/LLM/main/L0_MergeRequest_PR pipeline #25980 completed with status: 'SUCCESS'

@reasonsolo reasonsolo merged commit 93ae8a1 into NVIDIA:main Jan 27, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: PD disagg serving crash (exposed with Qwen-Coder client)

3 participants