Skip to content

Comments

[https://nvbugs/5836592][fix] Fix qwen3 eagle test#11030

Merged
schetlur-nv merged 1 commit intoNVIDIA:mainfrom
mikeiovine:fix-eagle-config
Jan 29, 2026
Merged

[https://nvbugs/5836592][fix] Fix qwen3 eagle test#11030
schetlur-nv merged 1 commit intoNVIDIA:mainfrom
mikeiovine:fix-eagle-config

Conversation

@mikeiovine
Copy link
Collaborator

@mikeiovine mikeiovine commented Jan 27, 2026

Description

Import was renamed to Eagle3DecodingConfig.

Test Coverage

Existing tests.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

Release Notes

  • Tests
    • Updated test configurations for Eagle-based speculative decoding to use the latest configuration standards. No functional changes to test behavior or coverage.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Mike Iovine <miovine@nvidia.com>
@mikeiovine
Copy link
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

A test file was updated to replace the EagleDecodingConfig class with Eagle3DecodingConfig in test methods that verify Eagle-based speculative decoding. The parameters (max_draft_len and speculative_model_dir) remain unchanged; only the config class instantiation was updated.

Changes

Cohort / File(s) Summary
Test decoding config update
tests/integration/defs/accuracy/test_llm_api_pytorch.py
Replaced EagleDecodingConfig instantiations with Eagle3DecodingConfig in Eagle3 test paths. Parameters (max_draft_len, speculative_model_dir) are preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change - fixing a qwen3 eagle test by updating the decoding config class.
Description check ✅ Passed The description explains the change (import renamed to Eagle3DecodingConfig) but lacks detail on why the change was necessary or what the fix addresses.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@tests/integration/defs/accuracy/test_llm_api_pytorch.py`:
- Around line 3725-3726: Replace the inconsistent keyword argument in the
Eagle3DecodingConfig instantiation: change the use of speculative_model_dir to
speculative_model so the call reads
Eagle3DecodingConfig(max_draft_len=draft_len,
speculative_model=eagle_model_dir), matching other usages and the file's naming
convention.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33747 [ run ] triggered by Bot. Commit: 94415a1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33747 [ run ] completed with state SUCCESS. Commit: 94415a1
/LLM/main/L0_MergeRequest_PR pipeline #26029 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@mikeiovine
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33915 [ run ] triggered by Bot. Commit: 94415a1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33915 [ run ] completed with state FAILURE. Commit: 94415a1
/LLM/main/L0_MergeRequest_PR pipeline #26155 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@mikeiovine
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34084 [ run ] triggered by Bot. Commit: 94415a1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34084 [ run ] completed with state SUCCESS. Commit: 94415a1
/LLM/main/L0_MergeRequest_PR pipeline #26298 completed with status: 'SUCCESS'

@schetlur-nv schetlur-nv merged commit 0ad8789 into NVIDIA:main Jan 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants