Skip to content

Comments

[None][chroe] Mass integration of release/1.2 - 2nd#11088

Merged
chzblych merged 21 commits intoNVIDIA:mainfrom
dominicshanshan:mi-release-1.2-2
Feb 2, 2026
Merged

[None][chroe] Mass integration of release/1.2 - 2nd#11088
chzblych merged 21 commits intoNVIDIA:mainfrom
dominicshanshan:mi-release-1.2-2

Conversation

@dominicshanshan
Copy link
Collaborator

@dominicshanshan dominicshanshan commented Jan 29, 2026

Description

This is weekly Mass Integration (MI) for release/1.2. Follow PR will not cherry back to main:

#10871 @yihwang-nv
#10836 (already in main)

and two infra PR with title: [None][infra] Check in most recent lock file from nightly pipeline

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Changes span multiple domains: removing mutex protection from KVCache descendant freeing, adjusting AllReduce strategy fallbacks, adding LoRA-awareness to Llama and attention modules to bypass quantization, updating speculative decoding interfaces with MLA flags, propagating mRoPE handles in disaggregated mode, and adjusting test configurations and test lists.

Changes

Cohort / File(s) Summary
KVCache Synchronization
cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp
Removed mutex locking guard in freeDescendantsRecursively(), eliminating synchronization protection for descendant block freeing. Potential data race risk when concurrent access occurs.
AllReduce Strategy Changes
cpp/tensorrt_llm/common/customAllReduceUtils.h, cpp/tensorrt_llm/thop/allreduceOp.cpp
Changed default fallback strategy from NCCL_SYMMETRIC to NCCL in lookup misses. Removed noexcept from AllreduceOp method signatures and added AllReduceStrategyType strategy parameter to runFusionAllReduce().
Kernel Synchronization & Comments
cpp/tensorrt_llm/kernels/quantization.cuh, cpp/tensorrt_llm/kernels/tinygemm2/tinygemm2_kernel.cuh
Added clarifying comment on SFScaleVal calculation. Reorganized synchronization in tinygemm2: added cudaTriggerProgrammaticLaunchCompletion() after initial __syncthreads() and added final __syncthreads() before kernel end.
LoRA Awareness in Models
tensorrt_llm/_torch/models/modeling_llama.py, tensorrt_llm/_torch/modules/attention.py
Introduced has_lora flag detection and propagation through Llama decoder and attention layers. When LoRA is active, quantization (FP8/NVFP4) is bypassed and fusion operators are adjusted to non-quantizing variants.
Speculative Decoding Interface Updates
tensorrt_llm/_torch/speculative/interface.py, tensorrt_llm/_torch/speculative/utils.py
Added is_mla: bool parameter to attention_need_spec_dec_mode() to determine xqa_supported based on MLA status. Updated MTP metadata construction to include allow_advanced_sampling parameter.
Executor & Model Engine Changes
tensorrt_llm/_torch/pyexecutor/model_engine.py, tensorrt_llm/_torch/pyexecutor/py_executor_creator.py, tensorrt_llm/_torch/pyexecutor/guided_decoder.py
Removed Eagle3OneModelSpecMetadata import and unified spec metadata handling. Added MLA flag calculation and reordered arguments in spec-decoding mode logic. Simplified speculative decoding warning path. Adjusted draft token rollback condition logic.
Disaggregated Parameters & API
tensorrt_llm/llmapi/llm.py, tensorrt_llm/llmapi/utils.py
Propagated mRoPE handles (mrope_position_ids, mrope_position_deltas) from multimodal config into disaggregated parameters. Removed @cache decorator from enable_worker_single_process_for_tp1().
Test Infrastructure Changes
tests/integration/defs/disaggregated/test_auto_scaling.py, tests/integration/defs/examples/serve/test_serve.py
Updated worker device allocation in auto-scaling test. Replaced hard-coded port defaults with explicit http_port parameters and dynamic port allocation in serve tests.
Test List Reconfigurations
tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/qa/llm_function_stress.txt, tests/integration/test_lists/waives.txt
Removed DeepSeekR1LongBenchV2 FP8/NVFP4 tests from core list and moved to stress list. Updated waive list with test suite reconfigurations.
Speculative Decoding & Multimodal Tests
tests/unittest/_torch/speculative/test_draft_len_schedule.py, tests/unittest/_torch/speculative/test_dynamic_spec_decode.py, tests/unittest/_torch/speculative/test_spec_gate.py
Changed enforce_single_worker fixture from module-scoped autouse to function-scoped with monkeypatch. Enabled previously-skipped test and added elaborate gating behavior verification with mocking. Added skip marker to test_dynamic_spec_decode.
LoRA & Multimodal Integration Tests
tests/unittest/_torch/multimodal/test_mm_encoder_standalone.py, tests/unittest/llmapi/test_llm_pytorch.py
Added DisaggregatedParams import and new test_pd_disagg_with_image_input() test for P/D disaggregation with images. Added new test_llama_3_3_70b_fp8_with_squad_lora_tp2() test for FP8 LoRA inference with similarity scoring.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

🚥 Pre-merge checks | ❌ 3
❌ Failed checks (1 warning, 2 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 42.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The PR title '[None][chroe] Mass integration of release/1.2 - 2nd' partially relates to the changeset as a mass integration, but contains a typo ('chroe' instead of 'chore') and is overly vague regarding the specific changes included. Correct the typo from 'chroe' to 'chore' and consider making the title more descriptive of key changes, or keep it concise if mass integration titles are standardized in this repo.
Description check ❓ Inconclusive PR description is minimal and vague. It references external PRs without detailing specific changes, and lacks comprehensive explanation of the integration work. Add a detailed summary of the key changes included in this mass integration, including the major bug fixes, test adjustments, and CI/infra updates. Explain the impact of changes like the LoRA support, synchronization fixes, and test list modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

Caution

Review failed

The head commit changed during the review from b270dcc to a86de0e.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (11)
tests/unittest/_torch/speculative/test_dynamic_spec_decode.py (1)

1-3: Add the NVIDIA copyright header (latest year).

This .py file should include the standard NVIDIA copyright header with the year of the latest meaningful modification (2026). Please align it with the format used elsewhere in the repo.
As per coding guidelines, all TensorRT-LLM source files (.py) should contain an NVIDIA copyright header with the year of latest meaningful modification.

tensorrt_llm/llmapi/utils.py (1)

1-1: Add the NVIDIA copyright header.

This source file is missing the required NVIDIA copyright header for the latest meaningful modification year (2026). Please add the standard header used in this repo at the top of the file.
As per coding guidelines: All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification.

tests/integration/defs/examples/serve/test_serve.py (1)

1-1: Add the NVIDIA copyright header for this modified source file.

The file is missing the required NVIDIA header with the latest modification year (2026). Please add the standard header used across the repo.

As per coding guidelines: All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification.

tensorrt_llm/_torch/pyexecutor/py_executor_creator.py (1)

1-1: Add the standard NVIDIA copyright header (year 2026).

This file lacks the required NVIDIA header. Please add the repo-standard header with the latest meaningful modification year (2026) at the top of the file.

🧾 Proposed header placement (use repo-standard wording)
+#
+# Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+#
 import copy

As per coding guidelines: "All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification."

cpp/tensorrt_llm/kernels/tinygemm2/tinygemm2_kernel.cuh (2)

1-3: Update the copyright year to 2026.

The file was modified in 2026, but the header still lists 2025 as the latest year. As per coding guidelines, All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification.


411-446: Move cudaTriggerProgrammaticLaunchCompletion() after epilogue writes and final synchronization.

The completion trigger at line 413 is called before warp 0 writes to output and profile buffers, violating proper ordering semantics. Even though the trigger itself does not enforce memory visibility, all writes must be logically complete before signaling kernel completion to dependent launches. Move the call below the final __syncthreads() and gate it to a single thread for clarity and correctness.

Reordering to move completion after writes
-        cudaTriggerProgrammaticLaunchCompletion();
-
         if (warp_id == 0)
         {
             ...
             if (PROFILE && blockIdx.y == 0 && threadIdx.x == 0)
                 profile[blockIdx.x].complete = gclock64();
         }
         __syncthreads();
+        if (threadIdx.x == 0)
+        {
+            cudaTriggerProgrammaticLaunchCompletion();
+        }
cpp/tensorrt_llm/common/customAllReduceUtils.h (1)

110-118: Stale comment: update to match the actual fallback behavior.

The comment on line 110 still references NCCL_SYMMETRIC as the fallback, but the code now returns NCCL. This inconsistency could confuse future maintainers.

📝 Proposed fix
-    // Check if the entry is out of bounds, otherwise return NCCL_SYMMETRIC as fallback
+    // Check if the entry is out of bounds, otherwise return NCCL as fallback
     if (AllReduceBestStrategyTable.find(sm_version) == AllReduceBestStrategyTable.end()
tensorrt_llm/_torch/models/modeling_llama.py (2)

1-1: Add the NVIDIA copyright header (2026).

The file starts with imports and is missing the required NVIDIA copyright header. Please insert the standard repo header with the latest modification year before any code.

As per coding guidelines, All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification.


780-815: LoRA+NVFP4/FP8 still quantizes when PRE_MLP_FUSION is off.

The LoRA bypass only applies to the fused path. When PRE_MLP_FUSION is false (e.g., TP=1 or fusion disabled), the non-fusion RMSNorm still sets nvfp4_scale, so LoRA grouped_gemm can still see quantized inputs. Please gate the non‑fusion path with the same has_lora check (or route through a non‑quantizing RMSNorm) so LoRA is safe in all configs.

🛠️ Suggested guard for the non‑fusion path
-        if self.PRE_MLP_FUSION:
-            has_lora = bool(kwargs.get('lora_params'))
+        has_lora = bool(kwargs.get('lora_params'))
+        if self.PRE_MLP_FUSION:
             ...
         else:
-            if self.is_nvfp4:
-                self.post_attention_layernorm.nvfp4_scale = self.mlp.gate_up_proj.input_scale
+            if self.is_nvfp4 and not has_lora:
+                self.post_attention_layernorm.nvfp4_scale = self.mlp.gate_up_proj.input_scale
+            elif self.is_nvfp4:
+                self.post_attention_layernorm.nvfp4_scale = None
             hidden_states, residual = self.post_attention_layernorm(
                 hidden_states, residual)
tensorrt_llm/_torch/pyexecutor/model_engine.py (1)

1-1: Add the NVIDIA copyright header (2026).

The file starts with imports and is missing the required NVIDIA copyright header. Please insert the standard repo header with the latest modification year before any code.

As per coding guidelines, All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification.

tensorrt_llm/_torch/modules/attention.py (1)

99-132: attn_custom_op_inplace does not propagate has_lora, breaking quantization bypass when torch compile is used with LoRA.

The custom op called during torch compilation (line 521) does not pass has_lora to _attn_impl. When LoRA is active in a torch-compiled model, this causes the quantization bypass logic at line 451 to fail—_attn_impl receives the default has_lora=False, enabling FP8 quantization despite LoRA grouped_gemm not supporting it. This breaks the quantization handling that is correctly applied in the non-compiled path (line 541).

Add has_lora as a parameter to attn_custom_op_inplace and propagate it from forward_impl (which receives it at line 504).

🤖 Fix all issues with AI agents
In `@tensorrt_llm/_torch/pyexecutor/model_engine.py`:
- Around line 53-54: Replace the direct-from import of Eagle3 symbols with a
namespaced module import: change "from ..speculative.eagle3 import
Eagle3ResourceManager, Eagle3SpecMetadata" to "from ..speculative import
eagle3", then update all usages to reference the namespaced classes: replace
Eagle3ResourceManager occurrences with eagle3.Eagle3ResourceManager (at the
sites currently using it) and replace Eagle3SpecMetadata occurrences with
eagle3.Eagle3SpecMetadata (update all six checks/uses named in the review).

In `@tests/integration/test_lists/waives.txt`:
- Line 302: Remove the duplicate waive entries by keeping one occurrence of each
test and deleting their second occurrences: remove the duplicate lines for
examples/test_ray.py::test_llm_inference_distributed_ray[tp2pp2],
llmapi/test_llm_examples.py::test_llmapi_tensorrt_engine, and
accuracy/test_llm_api_pytorch.py::TestLlama4ScoutInstruct::test_fp4[tp4-cuda_graph=True]
so each test ID appears only once in the waive list.

In `@tests/unittest/llmapi/test_llm_pytorch.py`:
- Around line 632-634: Add the missing pytest partition marker above the test
function test_llama_3_3_70b_fp8_with_squad_lora_tp2 by inserting the same style
marker used by the other LoRA tests in this file (e.g., `@pytest.mark.part1` or
the partition number used by nearby LoRA tests) so the test is included in the
correct CI partition; place the decorator directly above the
`@skip_gpu_memory_less_than_80gb/`@skip_ray decorators for the function
test_llama_3_3_70b_fp8_with_squad_lora_tp2.
🧹 Nitpick comments (8)
cpp/tensorrt_llm/kernels/quantization.cuh (2)

1-2: Consider updating the copyright year.

The copyright header shows 2019-2023, but this PR includes modifications dated 2026. As per coding guidelines, the copyright header should reflect the year of the latest meaningful modification.

📅 Proposed copyright year update
 /*
- * Copyright (c) 2019-2023, NVIDIA CORPORATION.  All rights reserved.
+ * Copyright (c) 2019-2026, NVIDIA CORPORATION.  All rights reserved.
  *

781-781: Minor: Add punctuation and consider clarifying the term "ACKBULK".

The comment should end with proper punctuation as per coding guidelines for full-sentence comments. Additionally, the term "ACKBULK" may not be immediately clear to future maintainers—consider briefly explaining what it refers to or providing a reference if it's project-specific terminology.

✏️ Suggested improvement
-    // This value is prepared by model, no need to be protected by ACKBULK
+    // This value is prepared by model, no need to be protected by ACKBULK.

Or with additional clarity:

-    // This value is prepared by model, no need to be protected by ACKBULK
+    // This value is prepared by the model; no ACKBULK protection is needed.
tests/integration/defs/disaggregated/test_auto_scaling.py (1)

464-469: Avoid unnecessary GPU overlap during worker restart.

At Line 468, gen_worker2 is started on device 0 while ctx_worker1 is still on device 0, even though device 1 was just freed. This adds avoidable contention and can introduce flakiness. Consider reusing the freed device for gen_worker2 and then placing ctx_worker2 on the other GPU once ctx_worker1 is terminated.

🔧 Proposed adjustment
-        gen_worker2 = run_gen_worker(model_name,
-                                     worker_config,
-                                     work_dir,
-                                     port=0,
-                                     device=0)
+        gen_worker2 = run_gen_worker(model_name,
+                                     worker_config,
+                                     work_dir,
+                                     port=0,
+                                     device=1)
@@
-        ctx_worker2 = run_ctx_worker(model_name,
-                                     worker_config,
-                                     work_dir,
-                                     port=0,
-                                     device=1)
+        ctx_worker2 = run_ctx_worker(model_name,
+                                     worker_config,
+                                     work_dir,
+                                     port=0,
+                                     device=0)

Also applies to: 486-490

tensorrt_llm/llmapi/utils.py (1)

18-37: Preserve the module namespace when importing functools.

Guidelines require module-level imports even for single symbols. Switch to import functools and use @functools.wraps.
As per coding guidelines: Always maintain the namespace when importing Python modules, even if only one class or function from a module is used.

♻️ Proposed refactor
-from functools import wraps
+import functools
@@
-    `@wraps`(func)
+    `@functools.wraps`(func)
     def wrapper(*args, **kwargs):
tests/unittest/_torch/speculative/test_draft_len_schedule.py (1)

18-22: LGTM! Fixture pattern is consistent with other speculative tests.

The change from module-scoped autouse to function-scoped with explicit monkeypatch is a good improvement—it provides better test isolation and automatic cleanup. Consider extracting this fixture to tests/unittest/_torch/speculative/conftest.py since identical definitions exist in test_dynamic_spec_decode.py, test_eagle3.py, and test_spec_gate.py.

tests/unittest/llmapi/test_llm_pytorch.py (1)

659-663: Use f-string conversion flag for repr().

Per static analysis (RUF010), prefer !r conversion flag over repr() calls in f-strings.

Suggested fix
-        print(f"Generated output: {repr(generated_text)}")
+        print(f"Generated output: {generated_text!r}")

         similarity = similarity_score(generated_text, expected_output)
         assert similar(generated_text, expected_output, threshold=0.8), \
-            f"Output similarity too low (similarity={similarity:.2%})!\nExpected: {repr(expected_output)}\nGot: {repr(generated_text)}"
+            f"Output similarity too low (similarity={similarity:.2%})!\nExpected: {expected_output!r}\nGot: {generated_text!r}"
tests/integration/defs/examples/serve/test_serve.py (1)

7-12: Keep the module namespace for the new defs.common import.

This addition breaks the “namespace imports only” rule. Prefer importing the module and calling through its namespace.

♻️ Suggested update
-from defs.common import get_free_port_in_ci
+import defs.common as common
...
-    port = get_free_port_in_ci()
+    port = common.get_free_port_in_ci()
...
-    port = get_free_port_in_ci()
+    port = common.get_free_port_in_ci()

As per coding guidelines: Always maintain the namespace when importing Python modules, even if only one class or function from a module is used.

tests/unittest/_torch/multimodal/test_mm_encoder_standalone.py (1)

287-337: Well-structured P/D disaggregation test.

The test correctly validates the disaggregated inference flow:

  1. Generates reference output with full inference
  2. Performs prefill with context_only and max_tokens=0
  3. Performs decode with generation_only using the disaggregated params
  4. Compares outputs for equivalence

Note: The static analysis warnings about unused model_dir and pd_disagg arguments are false positives - these parameters are used indirectly through pytest fixture parameterization (indirect=True).

Consider adding strict=True to the zip() calls on lines 330 and 334 to catch potential length mismatches early (Python 3.10+):

-    for i, (ref_output, test_output) in enumerate(zip(outputs_ref, outputs_pd)):
+    for i, (ref_output, test_output) in enumerate(zip(outputs_ref, outputs_pd, strict=True)):

,

Copy link
Collaborator

@yihwang-nv yihwang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! The PR #10871 can be ignored.

@dominicshanshan
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34006 [ run ] triggered by Bot. Commit: e20eae1

@dominicshanshan dominicshanshan force-pushed the mi-release-1.2-2 branch 2 times, most recently from 213e05b to 944bf56 Compare January 29, 2026 08:50
@dominicshanshan
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34028 [ run ] triggered by Bot. Commit: 944bf56

@dominicshanshan
Copy link
Collaborator Author

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34030 [ kill ] triggered by Bot. Commit: ffc0caf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34030 [ kill ] completed with state SUCCESS. Commit: ffc0caf
Successfully killed previous jobs for commit ffc0caf

pengbowang-nv and others added 5 commits February 1, 2026 21:43
…ts (NVIDIA#10855)

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
… mrope (NVIDIA#10865)

* Why?

Commit a6a8898 enabled EPD disaggregation for VLMs that use mrope (e.g.
qwen). However, this broke PD disaggregation for these sames models.

* What?

This commit fixes this, and adds a unit test that guards against it.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…3-70B-fp8 (NVIDIA#9808)

Signed-off-by: Michal Guzek <mguzek@nvidia.com>
Signed-off-by: Michal Guzek <moraxu@users.noreply.github.com>
Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Co-authored-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…ew requests, cherry-pick 10665 (NVIDIA#10817)

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
)

Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
lucaslie and others added 12 commits February 1, 2026 22:15
…on Hopper (NVIDIA#10729) (NVIDIA#10850)

Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Co-authored-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…y test (NVIDIA#10461) (NVIDIA#10851)

Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…A#10904)

Signed-off-by: Enwei Zhu <21126786+syuoni@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…tability for unit tests using single process mode (NVIDIA#10730)

Signed-off-by: Zheyu Fu <zheyuf@NVIDIA.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
… to insufficient memory (NVIDIA#10928)

Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
…kstart_advanced[GPT-OSS-120B-gpt_oss/gpt-oss-120b] (NVIDIA#10952)

Signed-off-by: Yihan Wang <yihwang@nvidia.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
)

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
@dominicshanshan
Copy link
Collaborator Author

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34414 [ run ] triggered by Bot. Commit: 22d93e2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34414 [ run ] completed with state SUCCESS. Commit: 22d93e2
/LLM/main/L0_MergeRequest_PR pipeline #26554 (Partly Tested) completed with status: 'SUCCESS'

@chzblych
Copy link
Collaborator

chzblych commented Feb 2, 2026

/bot skip ---comment "Passed LLM/main/L0_MergeRequest_PR pipeline #26388 and the follow-up rebase was for resolving a test waive list conflict"

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chzblych
Copy link
Collaborator

chzblych commented Feb 2, 2026

/bot skip --comment "Passed LLM/main/L0_MergeRequest_PR pipeline #26388 and the follow-up rebase was for resolving a test waive list conflict"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34430 [ skip ] triggered by Bot. Commit: 22d93e2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34430 [ skip ] completed with state SUCCESS. Commit: 22d93e2
Skipping testing for commit 22d93e2

@chzblych chzblych merged commit 13b0ab9 into NVIDIA:main Feb 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.