Skip to content

[https://nvbugs/5739981][fix] unwaive tests using opt-125M#11100

Merged
ixlmar merged 1 commit intoNVIDIA:mainfrom
ixlmar:test/cherry-pick-out-of-tree
Feb 3, 2026
Merged

[https://nvbugs/5739981][fix] unwaive tests using opt-125M#11100
ixlmar merged 1 commit intoNVIDIA:mainfrom
ixlmar:test/cherry-pick-out-of-tree

Conversation

@ixlmar
Copy link
Collaborator

@ixlmar ixlmar commented Jan 29, 2026

Description

Originally waived due to infra issue (mirrors release branch PR #11099)

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Tests
    • Enabled execution of previously-disabled tests for modeling and inference components, expanding automated test coverage to improve code quality and reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

@ixlmar
Copy link
Collaborator Author

ixlmar commented Jan 29, 2026

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

This change removes SKIP annotations from a test waives configuration file, re-enabling three previously-skipped tests: two parametrized instances of test_llm_api and one test_opt test.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Removed SKIP annotations for three tests: unittest/_torch/modeling/test_modeling_out_of_tree.py::TestOutOfTree::test_llm_api[False], test_llm_api[True], and triton_server/test_triton.py::test_opt[opt], enabling them to execute during test runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is incomplete. While it briefly explains the reason (infrastructure issue mirror), it lacks detail about which tests are being unwaived and lacks substantive content for the Description section. Expand the description to explicitly list which tests are being unwaived and provide more context about the infrastructure issue resolution.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main change: removing SKIP annotations (unwaiving) from tests that use the opt-125M model.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34050 [ run ] triggered by Bot. Commit: 17e8a76

@ixlmar
Copy link
Collaborator Author

ixlmar commented Jan 29, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34065 [ run ] triggered by Bot. Commit: 17e8a76

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34050 [ run ] completed with state ABORTED. Commit: 17e8a76
LLM/main/L0_MergeRequest_PR #26269 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34065 [ run ] completed with state SUCCESS. Commit: 17e8a76
/LLM/main/L0_MergeRequest_PR pipeline #26281 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@ixlmar
Copy link
Collaborator Author

ixlmar commented Jan 29, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34093 [ run ] triggered by Bot. Commit: 17e8a76

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34093 [ run ] completed with state SUCCESS. Commit: 17e8a76
/LLM/main/L0_MergeRequest_PR pipeline #26305 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@ixlmar ixlmar force-pushed the test/cherry-pick-out-of-tree branch from 17e8a76 to f2ccabf Compare February 2, 2026 09:54
@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 2, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34450 [ run ] triggered by Bot. Commit: f2ccabf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34450 [ run ] completed with state SUCCESS. Commit: f2ccabf
/LLM/main/L0_MergeRequest_PR pipeline #26578 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@ixlmar ixlmar changed the title [https://nvbugs/5318143][fix] unwaive tests using opt-125M [https://nvbugs/5739981][fix] unwaive tests using opt-125M Feb 2, 2026
@ixlmar ixlmar force-pushed the test/cherry-pick-out-of-tree branch from f2ccabf to 16328dc Compare February 2, 2026 11:48
@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 2, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34462 [ run ] triggered by Bot. Commit: 16328dc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34462 [ run ] completed with state SUCCESS. Commit: 16328dc
/LLM/main/L0_MergeRequest_PR pipeline #26587 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
@ixlmar ixlmar force-pushed the test/cherry-pick-out-of-tree branch from 16328dc to de9ad36 Compare February 2, 2026 15:40
@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 2, 2026

/bot run --disable-fail-fast

3 similar comments
@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 2, 2026

/bot run --disable-fail-fast

@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 2, 2026

/bot run --disable-fail-fast

@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 2, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34484 [ run ] triggered by Bot. Commit: de9ad36

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34484 [ run ] completed with state SUCCESS. Commit: de9ad36
/LLM/main/L0_MergeRequest_PR pipeline #26605 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 3, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34606 [ run ] triggered by Bot. Commit: de9ad36

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34606 [ run ] completed with state SUCCESS. Commit: de9ad36
/LLM/main/L0_MergeRequest_PR pipeline #26703 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@ixlmar
Copy link
Collaborator Author

ixlmar commented Feb 3, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34625 [ run ] triggered by Bot. Commit: de9ad36

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34625 [ run ] completed with state SUCCESS. Commit: de9ad36
/LLM/main/L0_MergeRequest_PR pipeline #26721 completed with status: 'SUCCESS'

@ixlmar ixlmar merged commit 710d6ef into NVIDIA:main Feb 3, 2026
5 checks passed
@ixlmar ixlmar deleted the test/cherry-pick-out-of-tree branch February 3, 2026 14:21
SchumiDing pushed a commit to SchumiDing/TensorRT-LLM that referenced this pull request Feb 6, 2026
)

Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants