[None][fix] Add an env var to turn off tinygemm

[dongfengy]

Summary by CodeRabbit

• New Features
  • Added ENABLE_TINYGEMM environment variable to provide users with explicit control over performance optimizations. By setting this variable to '1', users can now opt-in to advanced performance enhancement features, enabling more granular configuration options for different deployment environments and workload requirements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

Introduces a feature flag ENABLE_TINYGEMM read from an environment variable to make TinyGEMM optimization opt-in, instead of always activating it based on SM version checks. The flag must be explicitly enabled via environment variable.

Changes

Cohort / File(s)	Summary
TinyGEMM Feature Flag tensorrt_llm/_torch/models/modeling_gpt_oss.py	Added ENABLE_TINYGEMM environment variable parsing and guarded TinyGEMM optimization path to require both the flag and SM version checks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The PR description is incomplete, containing only the template structure without filling in critical sections like Description, Test Coverage, or PR title with ticket/issue reference.	Fill in the PR title following the template format with a ticket reference and type. Complete the Description section explaining the issue and solution. Document relevant test cases in the Test Coverage section.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding an environment variable to disable tinygemm optimization.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dongfengy]

/bot run

[tensorrt-cicd]

PR_Github #34267 [ run ] triggered by Bot. Commit: 14b5557

[tensorrt-cicd]

PR_Github #34267 [ run ] completed with state SUCCESS. Commit: 14b5557
/LLM/release-1.2.0rc2/L0_MergeRequest_PR pipeline #7 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[dongfengy]

/bot run

[tensorrt-cicd]

PR_Github #34272 [ skip ] triggered by Bot. Commit: 14b5557

[tensorrt-cicd]

PR_Github #34273 [ run ] triggered by Bot. Commit: 14b5557

[tensorrt-cicd]

PR_Github #34272 [ skip ] completed with state ABORTED. Commit: 14b5557

[tensorrt-cicd]

PR_Github #34273 [ run ] completed with state SUCCESS. Commit: 14b5557
/LLM/release-1.2.0rc2/L0_MergeRequest_PR pipeline #8 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[dongfengy]

/bot run

[tensorrt-cicd]

PR_Github #34277 [ run ] triggered by Bot. Commit: 14b5557

[tensorrt-cicd]

PR_Github #34277 [ run ] completed with state SUCCESS. Commit: 14b5557
/LLM/release-1.2.0rc2/L0_MergeRequest_PR pipeline #9 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[litaotju]

Hi @dongfengy, thanks for the PR! Before we can review this, could you help clarify a few things?

Context needed:
• What issue does disabling TinyGEMM by default solve? Is this a correctness bug or a performance regression?
• Are there specific models or configurations where TinyGEMM causes problems?
• Should users expect any performance impact from this change?

Process items:
• The PR description is currently empty - could you fill in the Description and Test Coverage sections per the template?
• CI is failing - are these failures related to this change or pre-existing flakiness?

Understanding the motivation will help us review and prioritize this appropriately. Thanks!

[dongfengy]

@litaotju It's not required anymore. It was a WAR during SA debugging. We have the proper fix merged.