[TRTLLM-10803][fix] Fix mocking of HuggingFace downloads in with_mocked_hf_download

[anish-shanbhag]

Description

unittest/_torch/speculative/test_eagle3.py::test_llama_eagle3[False-TRTLLM-True-False-False-False-True-False-False-True] and test_ad_speculative_decoding_smoke[True] are both intended to test the HuggingFace download codepath for speculative decoding which was introduced in #10099, but they were still supposed to mock out the actual download from HuggingFace, which was not actually being applied. This PR fixes the mocking behavior.

Note: test_ad_speculative_decoding_smoke is still waived due to https://nvbugs/5859869

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

• Tests
  • Improved test infrastructure for HuggingFace model mocking with corrected patch targeting and documentation.
  • Expanded test coverage for speculative model scenarios.

[coderabbitai]

📝 Walkthrough

Walkthrough

These changes expand test coverage and correct mock patching. The first change redirects the mock target for HuggingFace downloads to the correct local import binding location, with documentation notes. The second change adds a test parameter to include speculative HuggingFace model usage in test execution.

Changes

Cohort / File(s)	Summary
Mock Patching Fix tests/test_common/llm_data.py	Updated mock patch target from huggingface_hub.snapshot_download to tensorrt_llm.llmapi.utils.snapshot_download to match the local import binding location. Added NOTE blocks in decorator docstring and test wrapper documenting the import binding caveat.
Test Parameter Expansion tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_speculative_decoding.py	Added True to the use_hf_speculative_model parametrize marker, expanding test coverage to run with both False and True values for speculative HuggingFace model scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description explains the issue (mocking not being applied to HF download codepath) and solution (changing patch target), but does not clearly list test coverage that validates the fix.	Explicitly list which tests validate the mocking fix (e.g., test_llama_eagle3 and test_ad_speculative_decoding_smoke) under the Test Coverage section.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the fix as correcting HuggingFace download mocking in with_mocked_hf_download, directly matching the main change in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[anish-shanbhag]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #34498 [ run ] triggered by Bot. Commit: e5c14e6

[govind-ramnarayan]

Thanks!

[anish-shanbhag]

/bot kill

[tensorrt-cicd]

PR_Github #34498 [ run ] completed with state FAILURE. Commit: e5c14e6
/LLM/main/L0_MergeRequest_PR pipeline #26617 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[anish-shanbhag]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #34526 [ run ] triggered by Bot. Commit: b36b210

[tensorrt-cicd]

PR_Github #34526 [ run ] completed with state SUCCESS. Commit: b36b210
/LLM/main/L0_MergeRequest_PR pipeline #26641 completed with status: 'SUCCESS'