Skip to content

Comments

[TRTLLM-10839][infra] Set rerun report stage UNSTABLE and pipeline SUCCESS in post-merge when there are passed rerun tests#11210

Merged
yiqingy0 merged 1 commit intoNVIDIA:mainfrom
yiqingy0:update_rerun_repost_stage
Feb 3, 2026
Merged

[TRTLLM-10839][infra] Set rerun report stage UNSTABLE and pipeline SUCCESS in post-merge when there are passed rerun tests#11210
yiqingy0 merged 1 commit intoNVIDIA:mainfrom
yiqingy0:update_rerun_repost_stage

Conversation

@yiqingy0
Copy link
Collaborator

@yiqingy0 yiqingy0 commented Feb 3, 2026

Summary by CodeRabbit

  • Chores

    • Updated error handling for test rerun failures in CI/CD pipeline.
  • Bug Fixes

    • Rerun failures now correctly report as UNSTABLE status instead of causing immediate build failures, ensuring consistent error reporting across all job types.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

…en there are passed rerun tests

Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
@yiqingy0 yiqingy0 requested review from a team as code owners February 3, 2026 03:33
@yiqingy0 yiqingy0 changed the title Set rerun report stage UNSTABLE and pipeline SUCCESS in post-merge when there are passed rerun tests [TRTLLM-10839][infra] Set rerun report stage UNSTABLE and pipeline SUCCESS in post-merge when there are passed rerun tests Feb 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The PR simplifies error handling in the Rerun Report stage by removing conditional logic that differentiated behavior based on job type. The code now consistently wraps errors with catchError(buildResult: 'SUCCESS', stageResult: 'UNSTABLE'), ensuring rerun failures always result in an UNSTABLE stage outcome rather than conditionally failing the build.

Changes

Cohort / File(s) Summary
Rerun Report Error Handling
jenkins/L0_MergeRequest.groovy
Removed job-type-dependent conditional logic in collectTestResults. Now uses uniform error handling with buildResult: 'SUCCESS' and stageResult: 'UNSTABLE' for all rerun failures instead of branching between FAILURE and UNSTABLE based on job type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is mostly empty, containing only the template structure without any substantive content in the Description or Test Coverage sections. Fill in the Description section explaining the issue and solution, and the Test Coverage section listing relevant tests that validate the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: modifying rerun report stage behavior in post-merge pipelines to set stage to UNSTABLE and pipeline to SUCCESS when tests pass.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@jenkins/L0_MergeRequest.groovy`:
- Around line 919-922: The catchError block currently forces buildResult:
'SUCCESS' for all runs; change it so the SUCCESS scope applies only post‑merge
by using the repo's post‑merge detection (e.g., a boolean like isPostMerge or
checking env.CHANGE_ID/env.BRANCH_NAME) to choose the buildResult: use
buildResult: 'SUCCESS' and stageResult: 'UNSTABLE' only when post‑merge,
otherwise keep stricter pre‑merge behavior (omit or set a failing buildResult)
for the catchError that wraps the error "Some failed tests were reruned, please
check the rerun report."; update the catchError invocation accordingly so
pre‑merge pipelines are not forced to SUCCESS.

@yiqingy0
Copy link
Collaborator Author

yiqingy0 commented Feb 3, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34550 [ run ] triggered by Bot. Commit: 00687f4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34550 [ run ] completed with state SUCCESS. Commit: 00687f4
/LLM/main/L0_MergeRequest_PR pipeline #26661 completed with status: 'SUCCESS'

@yiqingy0 yiqingy0 merged commit a56aaa5 into NVIDIA:main Feb 3, 2026
6 of 11 checks passed
@yiqingy0 yiqingy0 deleted the update_rerun_repost_stage branch February 3, 2026 07:44
SchumiDing pushed a commit to SchumiDing/TensorRT-LLM that referenced this pull request Feb 6, 2026
…CCESS in post-merge when there are passed rerun tests (NVIDIA#11210)

Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants