[None][test] Enhance multi-GPU tests for IFB stats#11239
Conversation
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1,DGX_H100-2_GPUs-PyTorch-Others-2,DGX_H100-4_GPUs-PyTorch-Others-1,DGX_H200-4_GPUs-TensorRT-Post-Merge-1,DGX_H200-4_GPUs-TensorRT-Post-Merge-2,DGX_H200-4_GPUs-TensorRT-Post-Merge-3" |
Funatiq
changed the title
|
PR_Github #34674 [ run ] triggered by Bot. Commit: |
|
PR_Github #34674 [ run ] completed with state
|
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1,DGX_H100-2_GPUs-PyTorch-Others-2,DGX_H100-4_GPUs-PyTorch-Others-1" |
|
PR_Github #34690 [ run ] triggered by Bot. Commit: |
|
PR_Github #34690 [ run ] completed with state
|
Funatiq
force-pushed
the
dev/test_llm_get_stats_pp
branch
from
70c6d08 to
91fa80e
Compare
|
/bot run |
|
PR_Github #34750 [ run ] triggered by Bot. Commit: |
|
PR_Github #34824 [ run ] triggered by Bot. Commit: |
|
PR_Github #34824 [ run ] completed with state
|
|
/bot run |
|
PR_Github #34937 [ run ] triggered by Bot. Commit: |
|
PR_Github #34937 [ run ] completed with state
|
|
/bot run |
|
PR_Github #35107 [ run ] triggered by Bot. Commit: |
|
PR_Github #35107 [ run ] completed with state |
📝 WalkthroughWalkthroughTest suite restructuring changes validation logic for LLM stats filtering, removes pytorch_backend parameterization from multi-GPU tensor parallel tests while introducing pipeline parallel test coverage, and adds synchronized PyTorch backend-specific test variants. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/unittest/llmapi/test_llm_multi_gpu_pytorch.py`:
- Around line 173-190: The async harness llm_get_stats_async_test_harness is not
passing pipeline_parallel_size so tests like test_llm_get_stats_async_pp2
silently run with PP=1; update the harness where the LLM is constructed (the
with LLM_CLASS(...) block inside llm_get_stats_async_test_harness) to include
pipeline_parallel_size=pp_size (similar to llm_get_stats_test_harness), i.e.,
ensure pipeline_parallel_size is forwarded from the pp_size parameter (or added
to llm_args_extra) when instantiating LLM_CLASS so the async PP=2 tests actually
run with pipeline parallelism 2.
- Move PyTorch TP test cases to `test_llm_multi_gpu_pytorch.py`. - Add TRT PP test cases to `test_llm_multi_gpu.py`. - Add async test cases for PP tests. - Improve validation logic in `validate_stats` to filter results based on scheduled requests. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Funatiq
force-pushed
the
dev/test_llm_get_stats_pp
branch
from
91fa80e to
07159c2
Compare
|
/bot run |
|
PR_Github #35189 [ run ] triggered by Bot. Commit: |
|
PR_Github #35189 [ run ] completed with state |
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com> Signed-off-by: Ahmet Inci <ainci@nvidia.com>
3 participants
Summary by CodeRabbit
Description
test_llm_multi_gpu_pytorch.py.test_llm_multi_gpu.py.validate_statsto filter results based on scheduled requests.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.