Skip to content

Comments

[TRTLLM-10793][feat] Add BOLT compatible build flags for further experimental usage.#11297

Merged
hyukn merged 3 commits intoNVIDIA:mainfrom
hyukn:feat/host_bolt_flag
Feb 12, 2026
Merged

[TRTLLM-10793][feat] Add BOLT compatible build flags for further experimental usage.#11297
hyukn merged 3 commits intoNVIDIA:mainfrom
hyukn:feat/host_bolt_flag

Conversation

@hyukn
Copy link
Collaborator

@hyukn hyukn commented Feb 5, 2026

Summary by CodeRabbit

  • Chores
    • Added an optional build configuration option for BOLT compatibility support.
    • When enabled, applies specialized compiler and linker flags to optimize binary handling and preserve relocation information required for BOLT processing.
    • Ensures compatible dynamic linking for system libraries when BOLT optimization is active.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@hyukn hyukn force-pushed the feat/host_bolt_flag branch from adbd7bd to b7e0ff4 Compare February 5, 2026 16:12
@hyukn hyukn marked this pull request as ready for review February 5, 2026 16:13
@hyukn hyukn requested a review from a team as a code owner February 5, 2026 16:13
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

This PR adds BOLT compatibility support to the build system by introducing a new ENABLE_BOLT_COMPATIBLE CMake option that applies compiler/linker flags for BOLT instrumentation, disables binary stripping, configures conditional nanobind module building with NOSTRIP, and forces NVRTC dynamic linking when needed.

Changes

Cohort / File(s) Summary
BOLT Compatibility Configuration
cpp/CMakeLists.txt
Introduces ENABLE_BOLT_COMPATIBLE option (default OFF) that applies BOLT-specific compiler flags (-fno-reorder-blocks-and-partition, --fno-plt), linker flags (--emit-relocs), and disables binary stripping by setting CMAKE_STRIP to empty string when enabled (non-Windows only).
Conditional Module Building
cpp/tensorrt_llm/executor/cache_transmission/nixl_utils/CMakeLists.txt, cpp/tensorrt_llm/nanobind/CMakeLists.txt
Modifies nanobind module construction to conditionally apply NOSTRIP flag to nanobind_add_module calls when ENABLE_BOLT_COMPATIBLE is true, otherwise preserves original behavior.
Build Script Updates
scripts/build_wheel.py
Adds safeguard that forces NVRTC_DYNAMIC_LINKING=ON when ENABLE_BOLT_COMPATIBLE=ON is present in CMake variables, with explanatory message about static library relocation requirements.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description only contains the template with minimal substantive content; critical sections like Description, Test Coverage, and required checklist items are empty or incomplete. Complete the Description section explaining the issue and solution, add Test Coverage details, and fill in the PR checklist appropriately to meet repository guidelines.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically summarizes the main change—adding BOLT-compatible build flags with experimental status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
scripts/build_wheel.py (1)

1-3: ⚠️ Potential issue | 🟡 Minor

Update the NVIDIA copyright header year.

This file was modified in 2026, so the header should reflect the latest meaningful modification year.

📝 Suggested update
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.

As per coding guidelines: “All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification”.

🤖 Fix all issues with AI agents
In `@cpp/CMakeLists.txt`:
- Around line 372-399: The ENABLE_BOLT_COMPATIBLE block is currently only
guarded by NOT WIN32, which still runs on macOS and injects ELF/GNU-specific
flags; update the guard to explicitly target Linux/ELF (e.g., check for Linux or
UNIX and CMAKE_SYSTEM_NAME == "Linux") and, if ENABLE_BOLT_COMPATIBLE is set on
a non-Linux host, emit a fatal CMake error explaining BOLT is Linux/ELF-only.
Ensure you update the conditional that surrounds the modifications to
CMAKE_C_FLAGS, CMAKE_CXX_FLAGS, CMAKE_SHARED_LINKER_FLAGS,
CMAKE_MODULE_LINKER_FLAGS, CMAKE_EXE_LINKER_FLAGS, and the CMAKE_STRIP change so
those flags are only set on Linux; add the fatal error path to prevent
macOS/ld64 or other platforms from proceeding.

In `@scripts/build_wheel.py`:
- Around line 601-612: The BOLT detection currently only matches
"ENABLE_BOLT_COMPATIBLE=ON" so other CMake truthy values (TRUE/1/YES) are
missed; update the detection logic around bolt_enabled (which iterates
extra_cmake_vars) to treat any value after "ENABLE_BOLT_COMPATIBLE=" as truthy
by normalizing/rstripping and comparing against a set {"ON","TRUE","1","YES"}
(or parse the RHS case-insensitively) so that when bolt_enabled is true you
still append "-DNVRTC_DYNAMIC_LINKING=ON" to cmake_def_args if
nvrtc_dynamic_linking is false; also update the file header year from 2022-2025
to 2022-2026.

@dhansen-nvidia
Copy link
Collaborator

Overall, LGTM

…rimental usage.

Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
@hyukn hyukn force-pushed the feat/host_bolt_flag branch from b7e0ff4 to 063b12d Compare February 10, 2026 01:22
@hyukn
Copy link
Collaborator Author

hyukn commented Feb 10, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35388 [ run ] triggered by Bot. Commit: 063b12d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35388 [ run ] completed with state SUCCESS. Commit: 063b12d
/LLM/main/L0_MergeRequest_PR pipeline #27334 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hyukn
Copy link
Collaborator Author

hyukn commented Feb 10, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35425 [ run ] triggered by Bot. Commit: 063b12d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35425 [ run ] completed with state SUCCESS. Commit: 063b12d
/LLM/main/L0_MergeRequest_PR pipeline #27368 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hyukn
Copy link
Collaborator Author

hyukn commented Feb 10, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35510 [ run ] triggered by Bot. Commit: 063b12d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35510 [ run ] completed with state SUCCESS. Commit: 063b12d
/LLM/main/L0_MergeRequest_PR pipeline #27417 completed with status: 'SUCCESS'

Copy link
Collaborator

@tburt-nv tburt-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with these compiler options or BOLT, but this seems like a safe way to begin experimenting with them.

@hyukn hyukn merged commit 632c039 into NVIDIA:main Feb 12, 2026
5 checks passed
ekou24 pushed a commit to ekou24/TensorRT-LLM that referenced this pull request Feb 16, 2026
…rimental usage. (NVIDIA#11297)

Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants