[None][doc] add multiple-instances section in disaggregated serving doc#11412
[None][doc] add multiple-instances section in disaggregated serving doc#11412reasonsolo merged 1 commit intoNVIDIA:mainfrom
Conversation
📝 WalkthroughWalkthroughA new documentation subsection titled "Multiple Instances" is added to the disaggregated serving guide, describing deployment of multiple server instances across nodes to increase concurrency. The change includes example node mappings and client entrypoint guidance. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/source/features/disagg-serving.md`:
- Line 13: Update the Markdown link fragment for the "Multiple Instances" anchor
so it matches the auto-generated lowercase header anchor; find the link labeled
"[Multiple Instances]" in the document and change its fragment from
"#Multiple-Instances" to "#multiple-instances" so the link resolves correctly to
the section header.
- Line 221: Update the sentence "This is helpful when one disaggregated server
becomes performance bottleneck or runs out of ephemeral ports." to read "This is
helpful when one disaggregated server becomes a performance bottleneck or runs
out of ephemeral ports." — locate the sentence in the disagg-serving
documentation section (the line that mentions "disaggregated server becomes
performance bottleneck") and insert the article "a" before "performance
bottleneck" to fix the grammar.
🧹 Nitpick comments (2)
docs/source/features/disagg-serving.md (2)
234-234: Improve phrasing for client entrypoint guidance.The current phrasing "use a load balancer forwarding to" is grammatically awkward.
✍️ Suggested improvement
- - Send requests or use a load balancer forwarding to `node-a:8000` and `node-b:8000` + - Send requests directly or use a load balancer that forwards to `node-a:8000` and `node-b:8000`
219-235: Consider adding configuration guidance.The section provides a helpful example but could be enhanced with:
- A brief note on how to configure multiple orchestrator instances (e.g., duplicate
disagg_config.yamlon each node)- A mention of load balancing strategies (round-robin, least connections, etc.)
- Context on when ephemeral port exhaustion becomes an issue (high request rates, long-lived connections)
These additions would help users implement this deployment pattern more effectively, but the current content is sufficient for understanding the concept.
|
/bot skip --comment "doc only change" |
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
reasonsolo
force-pushed
the
multidisaggdoc
branch
from
495874f to
cd79c1b
Compare
|
/bot skip --comment "doc only change" |
|
PR_Github #35449 [ skip ] triggered by Bot. Commit: |
|
PR_Github #35451 [ skip ] triggered by Bot. Commit: |
|
PR_Github #35449 [ skip ] completed with state |
|
PR_Github #35451 [ skip ] completed with state |
5 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.