Skip to content

Comments

[None][doc] Add doc for TRTLLM AIGV initial release#11489

Merged
chang-l merged 3 commits intoNVIDIA:mainfrom
chang-l:user/liuc/aigv-doc-m1.1-github
Feb 15, 2026
Merged

[None][doc] Add doc for TRTLLM AIGV initial release#11489
chang-l merged 3 commits intoNVIDIA:mainfrom
chang-l:user/liuc/aigv-doc-m1.1-github

Conversation

@chang-l
Copy link
Collaborator

@chang-l chang-l commented Feb 13, 2026

Summary by CodeRabbit

  • Documentation
    • Added comprehensive documentation for Visual Generation feature, including diffusion-based model support in trtllm-serve.
    • Documented available endpoints for image and video generation capabilities.
    • Added quick-start guide, quantization details, and developer guidance for implementing custom diffusion models.
    • Updated documentation index to include new Visual Generation feature documentation.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

Three documentation files are added or modified to introduce and document the Visual Generation feature. A new comprehensive feature guide is created, the trtllm-serve command documentation is extended with a Visual Generation Serving section, and the main documentation index is updated to include the new feature documentation.

Changes

Cohort / File(s) Summary
Visual Generation Documentation
docs/source/features/visual-generation.md, docs/source/commands/trtllm-serve/trtllm-serve.rst, docs/source/index.rst
Added new feature documentation for Visual Generation (Diffusion Models) support, including quick start guides, usage examples, quantization details, developer guide, and OpenAI-compatible endpoints. Updated trtllm-serve documentation with Visual Generation Serving section and configuration options. Updated index to include new visual-generation feature page.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (72 files):

⚔️ README.md (content)
⚔️ cpp/include/tensorrt_llm/batch_manager/llmRequest.h (content)
⚔️ cpp/include/tensorrt_llm/executor/executor.h (content)
⚔️ cpp/include/tensorrt_llm/executor/serialization.h (content)
⚔️ cpp/include/tensorrt_llm/executor/types.h (content)
⚔️ cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp (content)
⚔️ cpp/tensorrt_llm/common/ncclUtils.cpp (content)
⚔️ cpp/tensorrt_llm/common/opUtils.h (content)
⚔️ cpp/tensorrt_llm/executor/multimodalInput.cpp (content)
⚔️ cpp/tensorrt_llm/executor/serialization.cpp (content)
⚔️ cpp/tensorrt_llm/executor/serializeUtils.h (content)
⚔️ cpp/tensorrt_llm/kernels/causalConv1d/causalConv1d.cu (content)
⚔️ cpp/tensorrt_llm/kernels/fusedLayernormKernels/layernorm_param.h (content)
⚔️ cpp/tensorrt_llm/kernels/fusedLayernormKernels/low_latency_layernorm.cuh (content)
⚔️ cpp/tensorrt_llm/kernels/fusedLayernormKernels/ws_layernorm.cuh (content)
⚔️ cpp/tensorrt_llm/kernels/fusedLayernormKernels/ws_layernorm.h (content)
⚔️ cpp/tensorrt_llm/kernels/fusedLayernormKernels/ws_layernorm_fp4_traits.cu (content)
⚔️ cpp/tensorrt_llm/nanobind/CMakeLists.txt (content)
⚔️ cpp/tensorrt_llm/nanobind/batch_manager/bindings.cpp (content)
⚔️ cpp/tensorrt_llm/nanobind/batch_manager/llmRequest.cpp (content)
⚔️ cpp/tensorrt_llm/nanobind/batch_manager/llmRequest.h (content)
⚔️ cpp/tensorrt_llm/nanobind/executor/bindings.cpp (content)
⚔️ cpp/tensorrt_llm/nanobind/executor/request.cpp (content)
⚔️ cpp/tensorrt_llm/plugins/CMakeLists.txt (content)
⚔️ cpp/tensorrt_llm/plugins/ncclPlugin/allreducePlugin.cpp (content)
⚔️ cpp/tensorrt_llm/runtime/CMakeLists.txt (content)
⚔️ cpp/tensorrt_llm/runtime/ipcNvlsMemory.cu (content)
⚔️ cpp/tensorrt_llm/thop/CMakeLists.txt (content)
⚔️ cpp/tensorrt_llm/thop/allreduceOp.cpp (content)
⚔️ cpp/tensorrt_llm/thop/fusedAddRMSNormQuant.cpp (content)
⚔️ cpp/tests/e2e_tests/batch_manager/trtGptModelTest.cpp (content)
⚔️ cpp/tests/unit_tests/batch_manager/kvCacheManagerTest.cpp (content)
⚔️ cpp/tests/unit_tests/batch_manager/microBatchSchedulerTest.cpp (content)
⚔️ cpp/tests/unit_tests/executor/serializeUtilsTest.cpp (content)
⚔️ cpp/tests/unit_tests/runtime/virtualMemoryTest.cpp (content)
⚔️ docs/source/commands/trtllm-serve/trtllm-serve.rst (content)
⚔️ docs/source/features/kvcache.md (content)
⚔️ docs/source/index.rst (content)
⚔️ examples/constraints.txt (content)
⚔️ tensorrt_llm/_torch/custom_ops/cpp_custom_ops.py (content)
⚔️ tensorrt_llm/_torch/custom_ops/torch_custom_ops.py (content)
⚔️ tensorrt_llm/_torch/models/modeling_nemotron_h.py (content)
⚔️ tensorrt_llm/_torch/modules/mamba/mamba2_metadata.py (content)
⚔️ tensorrt_llm/_torch/modules/mamba/mamba2_mixer.py (content)
⚔️ tensorrt_llm/_torch/modules/mamba/ssd_chunk_scan.py (content)
⚔️ tensorrt_llm/_torch/modules/mamba/ssd_chunk_state.py (content)
⚔️ tensorrt_llm/_torch/modules/mlp.py (content)
⚔️ tensorrt_llm/_torch/modules/rms_norm.py (content)
⚔️ tensorrt_llm/_torch/pyexecutor/_util.py (content)
⚔️ tensorrt_llm/_torch/pyexecutor/llm_request.py (content)
⚔️ tensorrt_llm/_torch/pyexecutor/mamba_cache_manager.py (content)
⚔️ tensorrt_llm/_torch/pyexecutor/model_engine.py (content)
⚔️ tensorrt_llm/_torch/pyexecutor/resource_manager.py (content)
⚔️ tensorrt_llm/_torch/pyexecutor/sampler.py (content)
⚔️ tensorrt_llm/_utils.py (content)
⚔️ tensorrt_llm/executor/base_worker.py (content)
⚔️ tensorrt_llm/inputs/data.py (content)
⚔️ tensorrt_llm/inputs/multimodal.py (content)
⚔️ tensorrt_llm/inputs/registry.py (content)
⚔️ tensorrt_llm/serve/openai_server.py (content)
⚔️ tensorrt_llm/tools/layer_wise_benchmarks/runner.py (content)
⚔️ tensorrt_llm/version.py (content)
⚔️ tests/integration/defs/perf/pytorch_model_config.py (content)
⚔️ tests/integration/defs/perf/test_perf.py (content)
⚔️ tests/integration/test_lists/qa/llm_spark_perf.yml (content)
⚔️ tests/integration/test_lists/test-db/l0_dgx_b200.yml (content)
⚔️ tests/integration/test_lists/test-db/l0_dgx_h100.yml (content)
⚔️ tests/integration/test_lists/waives.txt (content)
⚔️ tests/unittest/_torch/multimodal/test_mm_encoder_standalone.py (content)
⚔️ tests/unittest/_torch/sampler/test_torch_sampler.py (content)
⚔️ tests/unittest/bindings/test_executor_bindings.py (content)
⚔️ tests/unittest/llmapi/test_llm_kv_cache_events.py (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
Description check ⚠️ Warning PR description is incomplete. It lacks the required structure from the template including clear explanation of what/why, test coverage details, and properly filled PR checklist items. Complete the Description section with details on the visual generation feature. Fill in the Test Coverage section clearly. Ensure the PR title follows the template format with proper ticket reference and [type].
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the required template format [ticket/issue][type] and accurately summarizes the main change: adding documentation for TRTLLM AIGV (AI-Generated Visual) initial release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch user/liuc/aigv-doc-m1.1-github
  • Post resolved changes as copyable diffs in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Fix all issues with AI agents
In `@docs/source/features/visual-generation.md`:
- Around line 47-52: The bash example in the command that runs
visual_gen_wan_t2v.py uses a backslash followed by an inline comment which
breaks line continuation; update the command so each line-continuation backslash
is the last character (remove or move the comment after the backslash to its own
line or put the comment above the command), ensuring the invocation of
visual_gen_wan_t2v.py and its flags (--model_path
Wan-AI/Wan2.1-T2V-1.3B-Diffusers, --prompt, --height, --width, --num_frames,
--output_path) remain unchanged.
- Around line 77-78: The bash line continuation backslash is not the last
character on the first line; update the command so the backslash is the final
character (no trailing spaces or comments) to correctly continue the line for
trtllm-serve; specifically edit the invocation containing "trtllm-serve
Wan-AI/Wan2.1-T2V-1.3B-Diffusers" and the flag "--extra_visual_gen_options
wan_config.yml" so the backslash sits at the end of the first line and the
continuation line begins immediately with the next token.
- Around line 128-133: The bash snippet in the docs for running
visual_gen_wan_t2v.py has a backslash followed by an inline comment which breaks
line continuation; update the example invocation for visual_gen_wan_t2v.py (the
block showing --model_path Wan-AI/Wan2.1-T2V-1.3B-Diffusers \) so each trailing
backslash is the last character on the line—either move the comment to its own
preceding line or remove it—and ensure the continuation backslashes remain at
line ends for the full command (including --model_path, --prompt, --linear_type,
--output_path).
- Line 78: Update the docs to replace the unimplemented flag
`--extra_visual_gen_options` with the correct configuration flag `--config` (you
can also mention the alias `--extra_llm_api_options`) in the example so it reads
`--config wan_config.yml`; locate the occurrence of `--extra_visual_gen_options`
in the visual generation documentation and change it to `--config`, ensuring any
surrounding explanatory text references the correct option names.

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
@chang-l
Copy link
Collaborator Author

chang-l commented Feb 15, 2026

/bot skip --comment "doc update"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35980 [ skip ] triggered by Bot. Commit: 69c710d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35980 [ skip ] completed with state SUCCESS. Commit: 69c710d
Skipping testing for commit 69c710d

@chang-l chang-l merged commit b003355 into NVIDIA:main Feb 15, 2026
5 checks passed
peihu-nv pushed a commit to peihu-nv/TensorRT-LLM that referenced this pull request Feb 19, 2026
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Signed-off-by: peihu-nv <259410613+peihu-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants