[None][doc] Add doc for TRTLLM AIGV initial release#11489
[None][doc] Add doc for TRTLLM AIGV initial release#11489chang-l merged 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
📝 WalkthroughWalkthroughThree documentation files are added or modified to introduce and document the Visual Generation feature. A new comprehensive feature guide is created, the trtllm-serve command documentation is extended with a Visual Generation Serving section, and the main documentation index is updated to include the new feature documentation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@docs/source/features/visual-generation.md`:
- Around line 47-52: The bash example in the command that runs
visual_gen_wan_t2v.py uses a backslash followed by an inline comment which
breaks line continuation; update the command so each line-continuation backslash
is the last character (remove or move the comment after the backslash to its own
line or put the comment above the command), ensuring the invocation of
visual_gen_wan_t2v.py and its flags (--model_path
Wan-AI/Wan2.1-T2V-1.3B-Diffusers, --prompt, --height, --width, --num_frames,
--output_path) remain unchanged.
- Around line 77-78: The bash line continuation backslash is not the last
character on the first line; update the command so the backslash is the final
character (no trailing spaces or comments) to correctly continue the line for
trtllm-serve; specifically edit the invocation containing "trtllm-serve
Wan-AI/Wan2.1-T2V-1.3B-Diffusers" and the flag "--extra_visual_gen_options
wan_config.yml" so the backslash sits at the end of the first line and the
continuation line begins immediately with the next token.
- Around line 128-133: The bash snippet in the docs for running
visual_gen_wan_t2v.py has a backslash followed by an inline comment which breaks
line continuation; update the example invocation for visual_gen_wan_t2v.py (the
block showing --model_path Wan-AI/Wan2.1-T2V-1.3B-Diffusers \) so each trailing
backslash is the last character on the line—either move the comment to its own
preceding line or remove it—and ensure the continuation backslashes remain at
line ends for the full command (including --model_path, --prompt, --linear_type,
--output_path).
- Line 78: Update the docs to replace the unimplemented flag
`--extra_visual_gen_options` with the correct configuration flag `--config` (you
can also mention the alias `--extra_llm_api_options`) in the example so it reads
`--config wan_config.yml`; locate the occurrence of `--extra_visual_gen_options`
in the visual generation documentation and change it to `--config`, ensuring any
surrounding explanatory text references the correct option names.
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
|
/bot skip --comment "doc update" |
|
PR_Github #35980 [ skip ] triggered by Bot. Commit: |
|
PR_Github #35980 [ skip ] completed with state |
Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com> Signed-off-by: peihu-nv <259410613+peihu-nv@users.noreply.github.com>
Add visual generation documentation
Add trtllm-serve command documentation updates
Dependency
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.