[None][infra] Waive unittest that consistently timed out#11580
Conversation
|
/bot run --stage-list "H100_PCIe-PyTorch-Ray-1" |
📝 WalkthroughWalkthroughA test skip entry was added to the integration test waive list for a specific LLM weight update test case with the Qwen3-30B-A3B-FP8 model variant, referencing an associated bug tracking link. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
369-369: Use the shorthttps://nvbugs/XXXXXURL format.The new entry uses the long
nvbugspro.nvidia.comformat, while the preferred convention in this file is the shorthttps://nvbugs/XXXXXform. Change:-unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-30B-A3B-FP8] SKIP (https://nvbugspro.nvidia.com/bug/5911788) +unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-30B-A3B-FP8] SKIP (https://nvbugs/5911788)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/test_lists/waives.txt` at line 369, The test waiver line uses the long nvbugs URL; update the waiver entry for the test "unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-30B-A3B-FP8]" to use the short form "https://nvbugs/5911788" instead of "https://nvbugspro.nvidia.com/bug/5911788" so it matches the file's preferred convention.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 369: The test waiver line uses the long nvbugs URL; update the waiver
entry for the test
"unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-30B-A3B-FP8]"
to use the short form "https://nvbugs/5911788" instead of
"https://nvbugspro.nvidia.com/bug/5911788" so it matches the file's preferred
convention.
yuanjingx87
force-pushed
the
user/yuanjingx/waive_unittest_that_timed_out
branch
from
91dbbce to
d5170d3
Compare
|
/bot run --stage-list "H100_PCIe-PyTorch-Ray-1" |
|
PR_Github #36194 [ run ] triggered by Bot. Commit: |
|
PR_Github #36194 [ run ] completed with state
|
yuanjingx87
force-pushed
the
user/yuanjingx/waive_unittest_that_timed_out
branch
2 times, most recently
from
d1d70f1 to
105882f
Compare
|
/bot run --stage-list "H100_PCIe-PyTorch-Ray-1" |
|
PR_Github #36207 [ run ] triggered by Bot. Commit: |
yuanjingx87
force-pushed
the
user/yuanjingx/waive_unittest_that_timed_out
branch
from
105882f to
8bb3344
Compare
|
/bot run --stage-list "H100_PCIe-PyTorch-Ray-1" |
|
PR_Github #36218 [ run ] triggered by Bot. Commit: |
|
PR_Github #36207 [ run ] completed with state |
yuanjingx87
force-pushed
the
user/yuanjingx/waive_unittest_that_timed_out
branch
from
8bb3344 to
973fd5f
Compare
|
/bot run --stage-list "H100_PCIe-PyTorch-Ray-1" |
|
PR_Github #36218 [ run ] completed with state
|
|
/bot run --stage-list "H100_PCIe-PyTorch-Ray-1" |
|
PR_Github #36236 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "H100_PCIe-PyTorch-Ray-1" |
|
PR_Github #36245 [ run ] triggered by Bot. Commit: |
yuanjingx87
force-pushed
the
user/yuanjingx/waive_unittest_that_timed_out
branch
from
3fcdaf8 to
5d864a6
Compare
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
yuanjingx87
force-pushed
the
user/yuanjingx/waive_unittest_that_timed_out
branch
from
5d864a6 to
777607b
Compare
|
/bot skip --comment "partial run is sufficient" |
|
PR_Github #36259 [ skip ] triggered by Bot. Commit: |
|
PR_Github #36245 [ run ] completed with state |
|
PR_Github #36259 [ skip ] completed with state |
5 participants
Summary by CodeRabbit
Description
Waive timeout unittest in main premerge
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.