[https://nvbugs/5612438][fix] Add timeout for SeedOSS test#8683
[https://nvbugs/5612438][fix] Add timeout for SeedOSS test#8683byshiue merged 1 commit intoNVIDIA:mainfrom
Conversation
📝 WalkthroughWalkthroughA timeout decorator set to 7200 seconds was added to the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration/defs/accuracy/test_llm_api_pytorch.py (1)
3765-3765: LGTM! Timeout added appropriately.The 7200-second timeout is reasonable for this large model test and consistent with similar tests in the file (e.g., line 327, 567). This will prevent the test from hanging indefinitely.
Optional: Consider class-level placement for consistency.
For consistency with other large model test classes in this file (e.g.,
TestLlama3_3_70BInstructat line 567,TestLlama4MaverickInstructat line 680), consider moving the timeout decorator to the class level:+@pytest.mark.timeout(7200) class TestSeedOss_36B(LlmapiAccuracyTestHarness): MODEL_NAME = "ByteDance-Seed/Seed-OSS-36B-Instruct" MODEL_PATH = f"{llm_models_root()}/Seed-OSS/Seed-OSS-36B-Instruct" gsm8k_sampling_params = SamplingParams(temperature=1.1, top_p=0.95, max_tokens=16384) @skip_pre_hopper - @pytest.mark.timeout(7200) @pytest.mark.skip_less_device_memory(140000) def test_auto_dtype(self):This would future-proof the class if additional test methods are added later.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/integration/defs/accuracy/test_llm_api_pytorch.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
|
/bot run --post-merge |
|
PR_Github #22624 [ run ] triggered by Bot. Commit: |
|
PR_Github #22624 [ run ] completed with state |
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
2 times, most recently
from
fcaa958 to
4974850
Compare
|
/bot run --post-merge |
|
PR_Github #22653 [ run ] triggered by Bot. Commit: |
|
PR_Github #22653 [ run ] completed with state |
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
4974850 to
8023fc7
Compare
|
/bot run --post-merge |
|
PR_Github #22720 [ run ] triggered by Bot. Commit: |
|
PR_Github #22720 [ run ] completed with state |
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
8023fc7 to
0c9ec22
Compare
|
/bot run --post-merge |
|
PR_Github #22875 [ run ] triggered by Bot. Commit: |
|
PR_Github #22875 [ run ] completed with state |
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
0c9ec22 to
b3715ad
Compare
|
/bot run --post-merge |
|
PR_Github #22886 [ run ] triggered by Bot. Commit: |
|
PR_Github #22886 [ run ] completed with state |
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
b3715ad to
e87d2f8
Compare
|
/bot run --post-merge |
|
PR_Github #22910 [ run ] triggered by Bot. Commit: |
|
PR_Github #22910 [ run ] completed with state |
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
e87d2f8 to
ac864c3
Compare
|
/bot run --post-merge |
|
PR_Github #22958 [ run ] triggered by Bot. Commit: |
|
PR_Github #33038 [ run ] triggered by Bot. Commit: |
|
PR_Github #33038 [ run ] completed with state
|
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
e96eb91 to
ab99b54
Compare
|
/bot run --post-merge |
|
PR_Github #33339 [ run ] triggered by Bot. Commit: |
|
PR_Github #33339 [ run ] completed with state
|
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
ab99b54 to
2bc7cba
Compare
|
/bot run --post-merge |
|
PR_Github #33357 [ run ] triggered by Bot. Commit: |
|
PR_Github #33357 [ run ] completed with state
|
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
2bc7cba to
4424096
Compare
|
/bot run --post-merge |
|
PR_Github #33581 [ run ] triggered by Bot. Commit: |
|
PR_Github #33581 [ run ] completed with state
|
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
4424096 to
3015b74
Compare
|
/bot run --post-merge |
|
PR_Github #33666 [ run ] triggered by Bot. Commit: |
|
/bot kill |
|
PR_Github #33672 [ kill ] triggered by Bot. Commit: |
|
PR_Github #33672 [ kill ] completed with state |
|
/bot run --stage-list "B200_PCIe-PyTorch-Post-Merge-1, B200_PCIe-PyTorch-Post-Merge-2" |
|
PR_Github #33674 [ run ] triggered by Bot. Commit: |
|
PR_Github #33674 [ run ] completed with state |
Signed-off-by: Zhen Huang <145532724+zhhuang-nv@users.noreply.github.com>
zhhuang-nv
force-pushed
the
fix-nvbug-5612438
branch
from
3015b74 to
6452352
Compare
|
/bot skip --comment "The test case has run and passed in B200_PCIe-PyTorch-Post-Merge-1 stage" |
|
PR_Github #33691 [ skip ] triggered by Bot. Commit: |
|
PR_Github #33691 [ skip ] completed with state |
3 participants
Summary by CodeRabbit
Description
Add timeout (7200) for SeedOSS. Default value 3600 is not enough for this thinking model.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.