Use "purge-job" instead of "purge-jobs" when canceling a single job#742
Merged
zdohnal merged 3 commits intoOpenPrinting:masterfrom Jun 27, 2023
Merged
Use "purge-job" instead of "purge-jobs" when canceling a single job#742zdohnal merged 3 commits intoOpenPrinting:masterfrom
zdohnal merged 3 commits intoOpenPrinting:masterfrom
Conversation
The command "cancel -x <job>" adds "purge-jobs true" to the Cancel-Job operation; however, the correct attribute to use for Cancel-job is "purge-job" (singular), not "purge-jobs" (plural). As a result, job files are not removed from /var/spool/cups when "cancel -x <job>" is executed. This patch resolves the issue by adding "purge-job" when the IPP operation is Cancel-Job and "purge-jobs" for other IPP operations (Purge-Jobs, Cancel-Jobs, and Cancel-My-Jobs)
Member
|
@michaelrsweet would you mind looking into it? Only reference I found about purge-jobs/purge-job is that Purge Jobs operation is deprecated http://ftp.pwg.org/pub/pwg/standards/std-ipp20-20151030-5100.12.pdf . Bryan sent me a link to old pwg email conversation https://www.pwg.org/archives/ipp/2009/016226.html which mentions the attributes, but it looks it is not mention in IPP 2.0+ standard. |
Member
|
@zdohnal The "purge-job" attribute is a CUPS extension and has never been standardized. Given that it removes job history, the PWG is not interested in standardizing it (thus the deprecation of Purge-Jobs). |
michaelrsweet
requested changes
Jun 26, 2023
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
Just a minor coding style issue, otherwise LGTM.
michaelrsweet
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command "cancel -x " adds "purge-jobs true" to the Cancel-Job operation; however, the correct attribute to use for Cancel-job is "purge-job" (singular), not "purge-jobs" (plural). As a result, job files are not removed from /var/spool/cups when "cancel -x " is executed.