Merged
Conversation
Contributor
Author
|
First time taking a stab at this library, so a thorough review would be appreciated. |
Contributor
Author
|
Ping @macobo should we move this forward? |
Contributor
|
If we're doing |
Member
|
Definitely agree with support |
This was referenced Apr 22, 2021
neilkakkar
reviewed
May 6, 2021
| def test_basic_page_distinct_uuid(self): | ||
| client = self.client | ||
| distinct_id = uuid4() | ||
| distinct_id = str(uuid4()) |
Contributor
There was a problem hiding this comment.
Not sure how this worked before O.o
mariusandra
reviewed
May 7, 2021
Comment on lines
+74
to
+81
| def set_once(): | ||
| posthog.set_once( | ||
| options.distinct_id, | ||
| properties=json_hash(options.traits), | ||
| context=json_hash(options.context), | ||
| ) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Just a nit, but might be good to add "set" here for completion as well.
mariusandra
approved these changes
May 7, 2021
Contributor
|
Can you please still fix the black error... and then feel free to merge it into master :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
$setand$set_oncesupport to the library. Related to PostHog/posthog#2684.Further, makes things easier to test & run locally. Using
setup.py testis deprecated, and so istest_requires. Thus, I changed the test file names and added support for pytest so we can still test things. I didn't change any CI configuration, which hopefully gives confidence that the new and old testing methods are on par.If you're okay with this change, I can "upgrade"
ci.yamlas well.