Add label property to debug config, change pkg name to lowercase#1746
Merged
TylerLeonhardt merged 1 commit intomasterfrom Feb 8, 2019
Merged
Add label property to debug config, change pkg name to lowercase#1746TylerLeonhardt merged 1 commit intomasterfrom
TylerLeonhardt merged 1 commit intomasterfrom
Conversation
I don't think we should merge this to v1.x. I want to take the opportunity with the preview to make sure package.json name prop change to "powershell" doesn't cause any problems. This addresses issue caused w/LiveShare ext loaded and you try to debug. While this issue has been fixed by a mod to the next verson of VSCode, we should have our debugger configured properly. See microsoft/vscode#61649 Also, made debug snippet prop order consistent: name, type, request.
rjmholt
approved these changes
Feb 8, 2019
TylerLeonhardt
pushed a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
Mar 18, 2019
…erShell#1746) I don't think we should merge this to v1.x. I want to take the opportunity with the preview to make sure package.json name prop change to "powershell" doesn't cause any problems. This addresses issue caused w/LiveShare ext loaded and you try to debug. While this issue has been fixed by a mod to the next verson of VSCode, we should have our debugger configured properly. See microsoft/vscode#61649 Also, made debug snippet prop order consistent: name, type, request.
TylerLeonhardt
pushed a commit
that referenced
this pull request
Mar 20, 2019
I don't think we should merge this to v1.x. I want to take the opportunity with the preview to make sure package.json name prop change to "powershell" doesn't cause any problems. This addresses issue caused w/LiveShare ext loaded and you try to debug. While this issue has been fixed by a mod to the next verson of VSCode, we should have our debugger configured properly. See microsoft/vscode#61649 Also, made debug snippet prop order consistent: name, type, request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I don't think we should merge this to v1.x. I want to take the
opportunity with the preview to make sure package.json name prop change
to "powershell" doesn't cause any problems.
This addresses issue caused w/LiveShare ext loaded and you try to debug.
While this issue has been fixed by a mod to the next verson of VSCode,
we should have our debugger configured properly.
See microsoft/vscode#61649
Also, made debug snippet prop order consistent: name, type, request.
Fix #1590
Fix #1692
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready