Conversation
2colours
reviewed
Feb 7, 2026
only run if glossary is one of the specified test files Closes #4099
coke
force-pushed
the
coke/sort-glossary
branch
from
7c16b6c to
fe5911a
Compare
arkiuat
approved these changes
Feb 7, 2026
Collaborator
arkiuat
left a comment
arkiuat
left a comment
There was a problem hiding this comment.
The re-sort looks good, definitely an improvement. I'm not yet familiar enough with the rakudoc rakuAST node structure to judge the new test script, but I did read through it.
Collaborator
Author
|
Yah, I basically kept dumping things out until I could see the structure I wanted, which is how I found 435d0b4. I’m sure the test script could be cleaned up a bit. |
Collaborator
Author
|
Whoops, had wrong ticket linked in message. Should have been #4588 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… And make the test pass - it was definitely not sorted.