BUG: Add reference area factor correction to aero surfaces (solves #557)

[giovaniceotto]

Pull request type

• Code changes (bugfix, features)

Checklist

• Tests for the changes have been added (if needed)
• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant)

Current behavior

See #557.

New behavior

Issue #557 is fixed.

Breaking change

• No

TODO:

• Add tests to prevent similar issues from going undetected again.
• Update CHANGELOG.md.
• Bump up version to 1.2.1 and release hotfix. (Gui: different PR maybe?)

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d4ac946) 72.47% compared to head (643ea6e) 72.58%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
rocketpy/rocket/aero_surface.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   72.47%   72.58%   +0.10%     
==========================================
  Files          59       59              
  Lines        9567     9576       +9     
==========================================
+ Hits         6934     6951      +17     
+ Misses       2633     2625       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gui-FernandesBR]

Thank you so much for a fast resolution for this bug. Here comes my first review.

I will try to help with the remaining TODOs, let's coordinate it together.

I would appreciate hearing from you on the comments that I've added below.

[Gui-FernandesBR]

Let's open an issue to deal with the AeroComponent and ref_factor thread.

[lucasfourier]

Great work guys. The only thing left to do I guess would be to refactor the newly created tests. Gonna open an issue for that. I think there is room for creating fixtures, parametrizing, etc. However, for a hotfix this is more than enough.

[Gui-FernandesBR]

LGTM,

All credits go to @giovaniceotto (aka the wizard) for this fix.

[phmbressan]

Thanks for quickly solving the review comments @Gui-FernandesBR . Great fix by @giovaniceotto .